Skip to content

feat(Docker): partially remove dependent packages outside of planning/control #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Oct 11, 2024

Description

This PR partially resolves autowarefoundation/autoware_universe#8805.
The autoware_pcl_extensions and autoware_pointcloud_preprocessor dependencies still remain.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Oct 11, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit run:health-check Run health-check labels Oct 11, 2024
Copy link

github-actions bot commented Jan 9, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk changed the title feat(docker): remove dependent packages outside of planning/control feat(Docker): remove dependent packages outside of planning/control Mar 14, 2025
@youtalk youtalk marked this pull request as ready for review March 14, 2025 10:48
@youtalk youtalk requested a review from oguzkaganozt as a code owner March 14, 2025 10:48
@youtalk youtalk requested review from xmfcx and mitsudome-r March 14, 2025 10:48
@youtalk youtalk marked this pull request as draft March 14, 2025 11:13
@youtalk
Copy link
Member Author

youtalk commented Mar 14, 2025

autowarefoundation/autoware_universe#8805 (comment) says that the dependency on autoware_pointcloud_preprocessor has been resolved, but unfortunately, there still seems to be a dependency. I will investigate it.

https://github.com/autowarefoundation/autoware/actions/runs/13854988764/job/38769753727?pr=5331#step:5:1784

#62 [rosdep-universe-planning-control-depend 3/4] RUN /autoware/resolve_rosdep_keys.sh /autoware/src humble   > /rosdep-universe-planning-control-depend-packages.txt   && cat /rosdep-universe-planning-control-depend-packages.txt
#62 4.317 ERROR: no rosdep rule for 'autoware_pointcloud_preprocessor'

youtalk added 2 commits March 17, 2025 17:21
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk changed the title feat(Docker): remove dependent packages outside of planning/control feat(Docker): partially remove dependent packages outside of planning/control Mar 17, 2025
@youtalk youtalk marked this pull request as ready for review March 17, 2025 11:02
@youtalk youtalk closed this Mar 17, 2025
@github-project-automation github-project-automation bot moved this from Execution to Done in Open AD Kit Working Group Mar 17, 2025
@youtalk youtalk deleted the remove-pc-todo-comments branch March 17, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit run:health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

planning/control component is dependent on the packages outside of planning/control component
1 participant