This repository was archived by the owner on Apr 1, 2025. It is now read-only.
forked from tier4/awsim_sensor_kit_launch
-
Notifications
You must be signed in to change notification settings - Fork 9
feat: ring outlier filter and distortion correction node load from param file #6
Merged
xmfcx
merged 3 commits into
autowarefoundation:main
from
Aysenayilmaz:feat/ring-outlier-filter-load-from-param-file
Oct 2, 2024
Merged
feat: ring outlier filter and distortion correction node load from param file #6
xmfcx
merged 3 commits into
autowarefoundation:main
from
Aysenayilmaz:feat/ring-outlier-filter-load-from-param-file
Oct 2, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
Thank you for preparing this fix.
This is with |
Signed-off-by: A. Sena Yılmaz <[email protected]>
xmfcx
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, with these changes it is localizing and driving again!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR autowarefoundation/autoware_universe#8468 removes the default parameter, thus common_sensor_launch needs to load the ring outlier parameter from the parameter file.
Related links
@vividf @Ariiees @knzo25
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.