fix(cie): add missing export dependencies in cie_thread_configurator#47
Merged
atsushi421 merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
Signed-off-by: atsushi421 <atsushi.yano.2@tier4.jp>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes missing transitive dependency exports for the cie_thread_configurator ROS 2 package so downstream packages including its installed headers reliably find required dependencies.
Changes:
- Export
cie_config_msgs,yaml-cpp, andrclcppviaament_export_dependencies()to match usage in installed/public headers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cie_thread_configuratorwas missingament_export_dependenciesforcie_config_msgs,yaml-cpp, andrclcpp. These are all used in its public headers, so downstream packages that only depend oncie_thread_configuratorcould fail to build because the transitive dependencies were not found.This is the same issue as autowarefoundation/agnocast#1254.
Related links
How was this PR tested?
Notes for reviewers