diagnostic: Add method error diagnostic#169
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 66.25% 66.30% +0.05%
==========================================
Files 50 50
Lines 7803 7871 +68
==========================================
+ Hits 5170 5219 +49
- Misses 2633 2652 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aviatesk
force-pushed
the
avi/method-error
branch
from
515e42b to
2e6d7d4
Compare
aviatesk
changed the title
aviatesk
force-pushed
the
avi/method-error
branch
from
2e6d7d4 to
4dcd616
Compare
aviatesk
force-pushed
the
avi/method-error
branch
3 times, most recently
from
83a4b5f to
a6f4eb2
Compare
aviatesk
force-pushed
the
avi/method-error
branch
2 times, most recently
from
f61e58e to
e5f04a1
Compare
aviatesk
force-pushed
the
avi/method-error
branch
from
e5f04a1 to
3a2a7a3
Compare
aviatesk
changed the title
aviatesk
force-pushed
the
avi/method-error
branch
2 times, most recently
from
b747be8 to
9c7390b
Compare
aviatesk
force-pushed
the
avi/method-error
branch
2 times, most recently
from
3250500 to
819c7fb
Compare
aviatesk
changed the title
aviatesk
changed the title
aviatesk
force-pushed
the
avi/method-error
branch
4 times, most recently
from
74bd327 to
83737bc
Compare
aviatesk
changed the title
aviatesk
force-pushed
the
avi/method-error
branch
6 times, most recently
from
11df763 to
dfb9a25
Compare
aviatesk
force-pushed
the
avi/method-error
branch
from
dfb9a25 to
d9d1814
Compare
This commit is certainly quite useful as it does find new errors, but it's still difficult to identify where the errors are coming from, and it's still noisy in the current state. In particular, it even reports type instabilities in the code generated by `@testset`, so I'm not sure what to do about it.
aviatesk
force-pushed
the
avi/method-error
branch
2 times, most recently
from
11d1ce1 to
24d4c4a
Compare
aviatesk
force-pushed
the
avi/method-error
branch
from
24d4c4a to
bc7a8e7
Compare
aviatesk
added a commit
that referenced
this pull request
Feb 15, 2026
aviatesk
added a commit
that referenced
this pull request
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is certainly quite useful as it does find new errors, but it's still difficult to identify where the errors are coming from, and it's still noisy in the current state.
In particular, it even reports type instabilities in the code generated by
@testset, so I don't think we can merge this PR as is.