Merged
Conversation
aviatesk
approved these changes
Dec 8, 2025
Owner
aviatesk
left a comment
There was a problem hiding this comment.
Thank you for investigating and fixing this issue.
Since I don't use Windows, I haven't been able to actually verify the behavior, but I think your investigation and explanations are just accurate.
visr
added a commit
to visr/JETLS.jl
that referenced
this pull request
Dec 9, 2025
Fixes aviatesk#339, since aviatesk#372 was not sufficient.
aviatesk
pushed a commit
that referenced
this pull request
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #339.
There are two separate commits. The first replaces
jetls.exewithjetls.bat, as discussed in #332 and previously in #226.As noted in #339 we can only spawn batch scripts on Windows after setting
shellto true, for security considerations. Thespawndocs mention:Users can configure the path with
I'm not sure there is more to do from a security perspective, because any bad
jetls.batthat is earlier on the path, or bad custom path that is entered here can do harm.https://nodejs.org/api/child_process.html#child_processspawncommand-args-options
https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2
I'd prefer if Pkg apps would be .exe rather than .bat shims, using something like the Pixi trampoline:
https://pixi.sh/latest/global_tools/trampolines/
https://github.com/prefix-dev/pixi/tree/main/trampoline
But that is more of a Pkg issue.