utils_disk: fix the verbose value in umount function#4097
Closed
hellohellenmao wants to merge 1 commit intoavocado-framework:masterfrom
Closed
utils_disk: fix the verbose value in umount function#4097hellohellenmao wants to merge 1 commit intoavocado-framework:masterfrom
hellohellenmao wants to merge 1 commit intoavocado-framework:masterfrom
Conversation
Contributor
Author
|
@YongxueHong @zhencliu Could you please help to take a review here? Thanks |
zhencliu
reviewed
Apr 2, 2025
Need the verbose for debugging Signed-off-by: Tingting Mao <timao@redhat.com>
Contributor
Author
|
@YongxueHong @zhencliu Updated with thanks, and could you please help to review again? |
YongxueHong
reviewed
Apr 7, 2025
| return process.system(cmd, verbose=verbose) == 0 | ||
|
|
||
|
|
||
| def umount(src, dst, fstype=None, verbose=False, session=None): |
There was a problem hiding this comment.
Hi @hellohellenmao
I suggest that you could customize the argument for the test case, rather than change the default here since this change will affect the previous behaviors and we need to involve more reviewers to evaluate it.
In order to reduce the influence and satisfy your requirements, I suggest specifying verbose=True in your scenario.
Contributor
Author
There was a problem hiding this comment.
Ha, make sense. Will close this PR, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The available value for verbose in this fuction is a bool, but not 'verbose'
ID: 3635