Skip to content

utils_disk: fix the verbose value in umount function #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hellohellenmao wants to merge 1 commit into from
Closed

utils_disk: fix the verbose value in umount function #4097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion virttest/utils_disk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def mount(src, dst, fstype=None, options=None, verbose=False, session=None):
return process.system(cmd, verbose=verbose) == 0


def umount(src, dst, fstype=None, verbose=False, session=None):
Copy link
Copy Markdown

@YongxueHong YongxueHong Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hellohellenmao
I suggest that you could customize the argument for the test case, rather than change the default here since this change will affect the previous behaviors and we need to involve more reviewers to evaluate it.
In order to reduce the influence and satisfy your requirements, I suggest specifying verbose=True in your scenario.

Copy link
Copy Markdown
Contributor Author

@hellohellenmao hellohellenmao Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, make sense. Will close this PR, thanks.

def umount(src, dst, fstype=None, verbose=True, session=None):
"""
Umount src from dst, if src really mounted under dst.

Expand Down