qcontainer: handle unsupported parameters for scsi-generic driver#4353
Merged
YongxueHong merged 1 commit intoavocado-framework:masterfrom Apr 3, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds compatibility handling for the scsi-generic driver by resetting unsupported aio and cache parameters and logging warnings. It also includes a null check for the cache variable. Reviewers suggested failing explicitly with a ValueError for unsupported aio settings instead of falling back, and identified a typo in a log message where cache.direct was repeated.
Add validation to prevent setting unsupported aio and cache parameters for scsi-generic driver, which causes QEMU errors. When these parameters are detected, log warnings and set them to None. Signed-off-by: Yongxue Hong <yhong@redhat.com>
YongxueHong
force-pushed
the
KVMAUTOMA-5184
branch
from
8234a95 to
5a45bc6
Compare
Author
|
Hi @zhencliu @qingwangrh |
Contributor
|
The configuration works as expected, LGTM |
zhencliu
approved these changes
Apr 3, 2026
Author
|
Thanks all, let's merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation to prevent setting unsupported aio and cache parameters for scsi-generic driver, which causes QEMU errors. When these parameters are detected, log warnings and set them to None.
ID: 5184