Skip to content

qcontainer: handle unsupported parameters for scsi-generic driver #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YongxueHong merged 1 commit into from
Apr 3, 2026
+11 −1
Merged

qcontainer: handle unsupported parameters for scsi-generic driver #4353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion virttest/qemu_devices/qcontainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2729,6 +2729,9 @@ def define_hbas(
),
):
protocol_node.set_param("aio", aio)
if aio and fmt in ("scsi-generic",):
LOG.warning(f'The driver {fmt} does not support "aio: {aio}"')
protocol_node.set_param("aio", None)
Comment thread
YongxueHong marked this conversation as resolved.
else:
devices[-1].set_param("aio", aio)
if aio == "native":
Expand Down Expand Up @@ -2790,6 +2793,12 @@ def define_hbas(
self.cache_map[cache]["cache.direct"],
self.cache_map[cache]["cache.no-flush"],
)
if fmt in ("scsi-generic",):
LOG.warning(
f"The driver {fmt} does not support "
f'"cache.direct: {direct}, cache.no-flush: {no_flush}"'
)
direct, no_flush = (None, None)
dev.set_param("cache.direct", direct)
dev.set_param("cache.no-flush", no_flush)
if top_node is not protocol_node:
Expand Down Expand Up @@ -2962,7 +2971,8 @@ def define_hbas(
devices[-1].set_param("bootindex", bootindex)
if Flags.BLOCKDEV in self.caps:
if isinstance(protocol_node, qdevices.QBlockdevProtocolHostDevice):
self.cache_map[cache]["write-cache"] = None
if cache:
self.cache_map[cache]["write-cache"] = None
write_cache = None if not cache else self.cache_map[cache]["write-cache"]
devices[-1].set_param("write-cache", write_cache)
if "scsi-generic" == fmt:
Expand Down
Loading