fix: skip network monitoring for watchOS - #3272
Closed
lawmicha wants to merge 5 commits into
Closed
Conversation
This was referenced Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #
#3220
Description
Uses the changes from aws-amplify/aws-appsync-realtime-client-ios#139. See this for more details.
Testing
We need to run this app on a physical device to fully verify that the issue is fixed. However, running on a simulator, we can check that there are no logs around network monitoring.
The logs around networking monitoring looks like this:
Running the app on a simulator and then calling
DataStore.start()shows that there are no "Connectivity" related logshttps://github.com/lawmicha/watchOSTestApp/blob/main/logs/start.logs
General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.