feat: skip network monitoring for watchOS, add watchOS client timeout - #139
Open
lawmicha wants to merge 6 commits into
Open
feat: skip network monitoring for watchOS, add watchOS client timeout#139lawmicha wants to merge 6 commits into
lawmicha wants to merge 6 commits into
Conversation
9 tasks
lawmicha
marked this pull request as ready for review
October 4, 2023 16:35
lawmicha
marked this pull request as draft
November 9, 2023 14:50
lawmicha
changed the title
lawmicha
marked this pull request as ready for review
November 23, 2023 17:07
lawmicha
force-pushed
the
fix-watchos
branch
from
November 23, 2023 17:15
b503056 to
5527ceb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws-amplify/amplify-swift#3220
Testing done in aws-amplify/amplify-swift#3272
Description of changes:
Skip networking monitoring when it is watchOS platform. networking monitoring is an optimization that we can't do when NWPathMonitor returns "unsatisfied" even when there is a network on the physical watch device.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.