fix(codepipeline): stop E3701 flagging Fn::If OutputArtifact names as duplicates - #4594
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
… duplicates An OutputArtifacts Name given as an Fn::If is validated once per branch and each branch instance is visited twice at the identical path, so the rule compared the second visit against the entry it had just recorded for itself and reported the name as already defined. Record the instance path alongside the name and condition status and skip entries from the same path when checking for duplicates. Genuine duplicates at different paths are still reported. Fixes aws-cloudformation#4584
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #4584
Description of changes:
An
OutputArtifactsNamegiven as anFn::Ifis visited twice per branch at the identical path, so E3701 compared the second visit against the entry it had just recorded for itself and reported the name as already defined. The rule now records the instance path with each name and skips same-path entries; genuine duplicates at different paths still error.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.