Skip to content

fix(codepipeline): stop E3701 flagging Fn::If OutputArtifact names as duplicates #4594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sanjays2402 wants to merge 1 commit into
base: main
Choose a base branch
from
+47 −7
Open

fix(codepipeline): stop E3701 flagging Fn::If OutputArtifact names as duplicates #4594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/cfnlint/rules/resources/codepipeline/PipelineArtifactNames.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def __init__(self) -> None:
"Resources/AWS::CodePipeline::Pipeline/Properties/Stages/*/Actions/*/OutputArtifacts/*/Name",
],
)
self._output_artifact_names: dict[str, list[tuple[str, dict]]] = {}
self._output_artifact_names: dict[str, list[tuple[str, dict, tuple]]] = {}

def initialize(self, cfn):
self._output_artifact_names = {}
Expand All @@ -49,11 +49,14 @@ def validate(
if resource_name not in self._output_artifact_names:
self._output_artifact_names[resource_name] = []

path = tuple(validator.context.path.path)
if "OutputArtifacts" in validator.context.path.path:
for output_name, output_condition in self._output_artifact_names[
resource_name
]:
if output_name != instance:
for (
output_name,
output_condition,
output_path,
) in self._output_artifact_names[resource_name]:
if output_name != instance or output_path == path:
continue
try:
validator.evolve(
Expand All @@ -72,10 +75,10 @@ def validate(
pass

self._output_artifact_names[resource_name].append(
(instance, validator.context.conditions.status)
(instance, validator.context.conditions.status, path)
)
elif "InputArtifacts" in validator.context.path.path:
for output_name, output_condition in self._output_artifact_names[
for output_name, output_condition, _ in self._output_artifact_names[
resource_name
]:
if output_name != instance:
Expand Down
37 changes: 37 additions & 0 deletions test/unit/rules/resources/codepipeline/test_pipeline_artifact_names.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,43 @@ def _append_queues(queue1: Iterable, queue2: Iterable) -> deque:
),
],
),
(
[
(
"Foo",
_append_queues(
_standard_path,
[0, "Actions", 0, "OutputArtifacts", 0, "Name", "Fn::If", 1],
),
{"IsUsEast1": True},
),
(
"Foo",
_append_queues(
_standard_path,
[0, "Actions", 0, "OutputArtifacts", 0, "Name", "Fn::If", 1],
),
{"IsUsEast1": True},
),
(
"Bar",
_append_queues(
_standard_path,
[0, "Actions", 0, "OutputArtifacts", 0, "Name", "Fn::If", 2],
),
{"IsUsEast1": False},
),
(
"Bar",
_append_queues(
_standard_path,
[0, "Actions", 0, "OutputArtifacts", 0, "Name", "Fn::If", 2],
),
{"IsUsEast1": False},
),
],
[],
),
],
)
def test_validate(instances, expected, rule, validator):
Expand Down