Skip to content

Device Health: Make the warnings less aggressive #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

larsll
Copy link
Contributor

@larsll larsll commented Apr 29, 2025

  • Latency 95% was triggering too quickly, esp. if the mean latency was very low.
  • Delay triggering of warning to 3 reporting periods after starting inference.

@larsll larsll requested review from MarkitectRoss and Copilot April 29, 2025 18:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the warning thresholds to make them less aggressive by increasing the delay before triggering warnings and refactoring status comparison logic.

  • Delay warnings to trigger after 3 reporting periods instead of 2.
  • Introduce a new helper function, statusMinMax, for comparing device statuses.
Comments suppressed due to low confidence (2)

website/src/components/device-status-panel.tsx:174

  • [nitpick] The function name 'statusMinMax' could be made more descriptive (e.g., 'selectStatusByPriority') to clarify its purpose of choosing a status based on comparison of priorities.
const statusMinMax = (

website/src/components/device-status-panel.tsx:179

  • The statusPriority mapping in statusMinMax differs from the existing getStatusPriority function (which uses lower values for error and warning). Please verify that the updated priority values (error: 4, warning: 3, etc.) are intentional and consistent with the overall device status logic.
const statusPriority = {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant