Skip to content

Device Health: Make the warnings less aggressive #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkitectRoss merged 2 commits into from
May 2, 2025
Merged

Device Health: Make the warnings less aggressive #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e9bfb9
Make the warnings less agressive
larsll Apr 29, 2025
44bc9bb
Change description
larsll Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 50 additions & 13 deletions website/src/components/device-status-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,33 @@ const DeviceStatusPanel = ({ isInferenceRunning, setNotifications }: DeviceStatu
[checkStatus, updatesSinceInferenceStarted]
);

const statusMinMax = (
status1: "info" | "success" | "warning" | "error" | "stopped" | "pending",
status2: "info" | "success" | "warning" | "error" | "stopped" | "pending",
operator: "min" | "max"
): "info" | "success" | "warning" | "error" | "stopped" | "pending" => {
const statusPriority = {
error: 4,
warning: 3,
success: 2,
info: 1,
stopped: 0,
pending: -1,
};

if (operator === "min") {
return statusPriority[status1 as keyof typeof statusPriority] <
statusPriority[status2 as keyof typeof statusPriority]
? status1
: status2;
} else {
return statusPriority[status1 as keyof typeof statusPriority] >
statusPriority[status2 as keyof typeof statusPriority]
? status1
: status2;
}
};

const allAlerts = useMemo(
() => ({
system: {
Expand All @@ -192,7 +219,7 @@ const DeviceStatusPanel = ({ isInferenceRunning, setNotifications }: DeviceStatu
(metrics.cpuFreq / metrics.cpuFreqMax) * 100.0,
thresholds.cpu.frequency,
isInferenceRunning,
2,
3,
"info"
),
warningMessage: "CPU Frequency is low",
Expand All @@ -213,7 +240,7 @@ const DeviceStatusPanel = ({ isInferenceRunning, setNotifications }: DeviceStatu
metrics.cpuUsage,
thresholds.cpu.usage,
isInferenceRunning,
2,
3,
"info"
),
warningMessage: "CPU Usage is high",
Expand All @@ -225,7 +252,7 @@ const DeviceStatusPanel = ({ isInferenceRunning, setNotifications }: DeviceStatu
metrics.latencyMean,
thresholds.performance.latency_mean,
isInferenceRunning,
2,
3,
"stopped"
),
warningMessage: "Latency is high",
Expand All @@ -234,15 +261,25 @@ const DeviceStatusPanel = ({ isInferenceRunning, setNotifications }: DeviceStatu
},
"device-status-latency-p95": {
metricValue: metrics.latencyP95 / metrics.latencyMean,
status: checkStatusWithInference(
metrics.latencyP95 / metrics.latencyMean,
thresholds.performance.latency_p95,
isInferenceRunning,
2,
"stopped"
status: statusMinMax(
checkStatusWithInference(
metrics.latencyP95 / metrics.latencyMean,
thresholds.performance.latency_p95,
isInferenceRunning,
3,
"stopped"
),
checkStatusWithInference(
metrics.latencyP95,
thresholds.performance.latency_mean,
isInferenceRunning,
3,
"stopped"
),
"min"
),
warningMessage: "95% Latency is high",
errorMessage: "95% Latency is critically high",
warningMessage: "Latency (95th percentile) is high",
errorMessage: "Latency (95th percentile) is critically high",
noInferenceStatus: "stopped" as "info" | "stopped" | "pending",
},
"device-status-fps-mean": {
Expand All @@ -251,7 +288,7 @@ const DeviceStatusPanel = ({ isInferenceRunning, setNotifications }: DeviceStatu
30.0 / metrics.fpsMean,
thresholds.performance.fps_mean,
isInferenceRunning,
2,
3,
"stopped"
),
warningMessage: "Frame Rate is low",
Expand Down Expand Up @@ -317,7 +354,7 @@ const DeviceStatusPanel = ({ isInferenceRunning, setNotifications }: DeviceStatu
}
});
}, [addFlashMessage, removeFlashMessage, allAlerts.system]);

useEffect(() => {
// Handle combined performance metrics alert
const performanceAlertId = "device-status-performance";
Expand Down