Skip to content

Fix script injection GitHub actions #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yitingb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix script injection GitHub actions #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,16 @@ jobs:
- name: Convert Jacoco integ test report to Cobertura
run: python3 .github/scripts/cover2cover.py target/jacoco-report/jacoco-it/jacoco.xml src/main/java > target/jacoco-report/cobertura-it.xml
- name: Save PR number
env:
PR_NUMBER: ${{ github.event.number }}
PR_SHA: ${{ github.event.pull_request.head.sha }}
run: |
mkdir -p ./pr/jacoco-report
echo "$PR_NUMBER" | tr -cd '0-9' > ./pr/NR
echo "$PR_SHA" | tr -cd 'a-fA-F0-9' > ./pr/SHA

# Safely extract and sanitize PR number using GITHUB_EVENT_PATH
PR_NUMBER=$(jq -r '.number // empty' "$GITHUB_EVENT_PATH" | tr -cd '0-9')
echo "$PR_NUMBER" > ./pr/NR

# Safely extract and sanitize PR SHA using GITHUB_EVENT_PATH
PR_SHA=$(jq -r '.pull_request.head.sha // empty' "$GITHUB_EVENT_PATH" | tr -cd 'a-fA-F0-9')
echo "$PR_SHA" > ./pr/SHA

cp target/jacoco-report/cobertura.xml ./pr/jacoco-report/cobertura.xml
cp target/jacoco-report/cobertura-it.xml ./pr/jacoco-report/cobertura-it.xml
Expand Down
Loading