Implement exponential backoff by configuring kube-client env vars #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky333999
reviewed
Mar 27, 2025
| @@ -1451,3 +1451,7 @@ neuronMonitor: | |||
| - SYS_ADMIN | |||
| serviceAccount: | |||
| name: # override exporter service account name | |||
| k8sClientExponentialBackoff: | |||
There was a problem hiding this comment.
Defining this at the global level sets an expectation that this will be respected for all k8s clients across every component deployed by this chart, including the operator, agent, fluentbit and anything else - but we arent doing that.
So making this agent specific might be better - but then why is this being defined as a helm override for the agent and not part of the agent json config like everything else.
We need more discussions on where these belong.
There was a problem hiding this comment.
Yeah, completely agree. We should discuss this.
|
We should test this to ensure that it does actually reduce the number of control plane api calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The CloudWatch Agent overloads the API server due to there not being an exponential back-off strategy implemented in the Kubernetes client when there's a timeout issue, as described in cilium/cilium#36525 (comment).
This change configures environmental variables that enables exponential back-off for timeout issues.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.