Skip to content

Implement exponential backoff by configuring kube-client env vars #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement exponential backoff by configuring kube-client env vars #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions charts/amazon-cloudwatch-observability/templates/linux/cloudwatch-agent-custom-resource.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,12 @@ spec:
- name: K8S_CLUSTER_NAME
value: {{ $.Values.clusterName }}
{{- with $.Values.tolerations }}
{{- if $.Values.k8sClientExponentialBackoff.enabled }}
- name: KUBE_CLIENT_BACKOFF_BASE
value: {{ $.Values.k8sClientExponentialBackoff.backoffBaseSeconds | quote }}
- name: KUBE_CLIENT_BACKOFF_DURATION
value: {{ $.Values.k8sClientExponentialBackoff.backoffMaxDurationSeconds | quote }}
{{- end }}
tolerations: {{- toYaml . | nindent 2}}
{{- end }}
---
Expand Down
4 changes: 4 additions & 0 deletions charts/amazon-cloudwatch-observability/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1451,3 +1451,7 @@ neuronMonitor:
- SYS_ADMIN
serviceAccount:
name: # override exporter service account name
k8sClientExponentialBackoff:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defining this at the global level sets an expectation that this will be respected for all k8s clients across every component deployed by this chart, including the operator, agent, fluentbit and anything else - but we arent doing that.

So making this agent specific might be better - but then why is this being defined as a helm override for the agent and not part of the agent json config like everything else.

We need more discussions on where these belong.

Copy link
Collaborator Author

@musa-asad musa-asad Apr 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, completely agree. We should discuss this.

enabled: true
backoffBaseSeconds: 1
backoffMaxDurationSeconds: 120