feat: Add flags to optionally disable DCGM Exporter, Neuron Monitor resources - #190
Conversation
KKamJi98
left a comment
There was a problem hiding this comment.
This PR introduces optional flags to disable DCGM Exporter, Neuron Monitor, and Windows-specific CloudWatch Agent components in the Helm chart.
The goal is to make the chart more flexible across environments where those components are not needed.
Please let me know if any changes are required or if you'd like additional test coverage.
|
Can't get why |
|
@dansimov04012022 W! {"caller":"internal/transaction.go:125","msg":"Failed to scrape Prometheus endpoint","kind":"receiver", ... ,"target_labels":"{__name__=\"up\", instance=\"dcgm-exporter-service.amazon-cloudwatch.svc:9400\", job=\"containerInsightsDCGMExporterScraper\"}"}Being able to disable these components with enabled: false flags will eliminate the unused resources and stop the noise in our logs. |
|
Hi @KKamJi98 .. thanks for making these changes. I think its fair to have flags that control whether or not these resources should be created. (Do note that the resources such as the actual daemonset objects are created, but the actual pods are only spun if they find appropriate nodes - so you shouldnt be seeing wasted cpu or mem even in the current state) Would you mind leaving out windows from this change? There's some ongoing discussions on how to restructure windows to better match the multi-agent pattern under |
KKamJi98
left a comment
There was a problem hiding this comment.
@sky333999 Thanks for the review! I’ve made the requested changes and pushed the commit.
|
Thanks for your contribution @KKamJi98 ! |
Description of changes:
This change introduces new Helm chart flags:
.Values.dcgmExporter.enabled.Values.neuronMonitor.enabled.Values.windows.enabledBy setting them to
false, undesired resources (DCGM Exporter, Neuron Monitor, Windows) are not deployed, thereby preventing unnecessary warnings in logs.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.