Skip to content

feat: Add flags to optionally disable DCGM Exporter, Neuron Monitor resources #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sky333999 merged 9 commits into from
Jul 21, 2025
Merged

feat: Add flags to optionally disable DCGM Exporter, Neuron Monitor resources #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
901c247
feat: add flags to disable dcgm-exporter, neuron-monitor, and windows…
KKamJi98 Mar 31, 2025
d4423d7
feat: add flags to disable dcgm-exporter, neuron-monitor, and windows…
KKamJi98 Mar 31, 2025
cce6634
feat: add flags to disable dcgm-exporter, neuron-monitor, and windows…
KKamJi98 Mar 31, 2025
8178067
Update RELEASE_NOTES
KKamJi98 Mar 31, 2025
4b681f8
Merge branch 'main' into main
KKamJi98 Jun 7, 2025
4493712
Merge branch 'aws-observability:main' into main
KKamJi98 Jul 10, 2025
cb9d0f6
feat: Add flags to control resource creation
KKamJi98 Jul 10, 2025
c19e59f
style: Adjust newline in fluent-bit-windows-daemonset
KKamJi98 Jul 10, 2025
daf6247
fix: Add missing {{- end }} to daemonset templates
KKamJi98 Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion charts/amazon-cloudwatch-observability/templates/linux/dcgm-exporter-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.dcgmExporter.enabled }}
apiVersion: cloudwatch.aws.amazon.com/v1alpha1
kind: DcgmExporter
metadata:
Expand Down Expand Up @@ -66,4 +67,5 @@ spec:
tls_server_config:
cert_file: /etc/amazon-cloudwatch-observability-dcgm-cert/server.crt
key_file: /etc/amazon-cloudwatch-observability-dcgm-cert/server.key
{{- dict "component" .Values.dcgmExporter "context" . | include "amazon-cloudwatch-observability.common.tolerations" | nindent 2 }}
{{- dict "component" .Values.dcgmExporter "context" . | include "amazon-cloudwatch-observability.common.tolerations" | nindent 2 }}
{{- end }}
2 changes: 2 additions & 0 deletions charts/amazon-cloudwatch-observability/templates/linux/dcgm-exporter-role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.dcgmExporter.enabled }}
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
Expand All @@ -10,3 +11,4 @@ rules:
resources: ["configmaps"]
resourceNames: ["{{ .Values.dcgmExporter.configmap }}"]
verbs: ["get"]
{{- end }}
2 changes: 2 additions & 0 deletions charts/amazon-cloudwatch-observability/templates/linux/dcgm-exporter-rolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.dcgmExporter.enabled }}
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
Expand All @@ -13,3 +14,4 @@ subjects:
- kind: ServiceAccount
name: {{ template "dcgm-exporter.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
{{- end }}
4 changes: 3 additions & 1 deletion charts/amazon-cloudwatch-observability/templates/linux/neuron-monitor-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.neuronMonitor.enabled }}
Comment thread
KKamJi98 marked this conversation as resolved.
apiVersion: cloudwatch.aws.amazon.com/v1alpha1
kind: NeuronMonitor
metadata:
Expand Down Expand Up @@ -83,4 +84,5 @@ spec:
}
]
}
{{- dict "component" .Values.neuronMonitor "context" . | include "amazon-cloudwatch-observability.common.tolerations" | nindent 2 }}
{{- dict "component" .Values.neuronMonitor "context" . | include "amazon-cloudwatch-observability.common.tolerations" | nindent 2 }}
{{- end }}
2 changes: 2 additions & 0 deletions charts/amazon-cloudwatch-observability/templates/linux/neuron-monitor-exporter-role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.neuronMonitor.enabled }}
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
Expand All @@ -10,3 +11,4 @@ rules:
resources: ["configmaps"]
resourceNames: ["{{ .Values.neuronMonitor.configmap }}"]
verbs: ["get"]
{{- end }}
2 changes: 2 additions & 0 deletions .../amazon-cloudwatch-observability/templates/linux/neuron-monitor-exporter-rolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.neuronMonitor.enabled }}
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
Expand All @@ -13,3 +14,4 @@ subjects:
- kind: ServiceAccount
name: {{ include "neuron-monitor.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
{{- end }}
4 changes: 3 additions & 1 deletion charts/amazon-cloudwatch-observability/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,6 +1334,7 @@ agent:
prometheusCR:
enabled: false
dcgmExporter:
enabled: true
name:
image:
repository: dcgm-exporter
Expand Down Expand Up @@ -1504,6 +1505,7 @@ dcgmExporter:
nodeSelector:
kubernetes.io/os: linux
neuronMonitor:
enabled: true
name:
image:
repository: neuron-monitor
Expand Down Expand Up @@ -1574,4 +1576,4 @@ neuronMonitor:
values:
- fargate
nodeSelector:
kubernetes.io/os: linux
kubernetes.io/os: linux
Loading