[Bugfix] EMF exporter not handling prometheus config in container envs (EKS/ECS) correctly - #1844
Merged
Conversation
lisguo
approved these changes
Sep 3, 2025
| ) | ||
|
|
||
| // func variable to override in tests | ||
| var isEcsFunc = func() bool { |
Contributor
There was a problem hiding this comment.
nit: Can move this function into the translator struct to make it easier to mock
dricross
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
The config translation logic for AWS EMF exporter doesn't handle
prometheusblock correctly by picking up a wrong component config template when there are additional config blocks such askubernetesorecs. This issue makes prometheus data being exported toundefiendlog stream undercontainerinsightslog group (/aws/containerinsights/{clusterName}/performance)EKS Addon advanced config:
Resulting
prometheusconfig block inamazon-cloudwatch-agent.yaml:Description of changes
prometheusand ECS environment validations to condition checks for more robust config processingkubernetesprocessing to the bottom of if/else chain to avoid any accidental translation issuesLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
unit tests and a test EKS cluster to verify translated yaml file and prometheus EMF logs being emitted to the correct log stream/group.
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.