add ipamd readiness latency metrics#3301
Merged
oliviassss merged 3 commits intoaws:masterfrom Jun 6, 2025
Merged
Conversation
beacffc to
dc69ddb
Compare
jaydeokar
reviewed
Jun 3, 2025
| ) | ||
| IpamdStartupAwsDuration = prometheus.NewHistogramVec( | ||
| prometheus.HistogramOpts{ | ||
| Name: "awscni_ipamd_startup_aws_duration_seconds", |
Collaborator
There was a problem hiding this comment.
nit - Can we name this something like "awscni_ipamd_node_initialization_seconds" ? We do more than just aws api calls..
fe95b90 to
427a3e2
Compare
jaydeokar
reviewed
Jun 6, 2025
| if err != nil { | ||
| log.Errorf("Initialization failure: %v", err) | ||
| // Record failed IPAMD initialization and failed startup | ||
| metrics.IpamdNodeInitDuration.WithLabelValues("false").Observe(IPAMDNodeInitDuration) |
Collaborator
There was a problem hiding this comment.
This metric might not be that useful for cases where success: false as when ipamd initialization fails, it will be in a crashloop continuously.
jaydeokar
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
improvement
Which issue does this PR fix?:
What does this PR do / Why do we need it?:
Add 2 historgram prom metrics to track:
awscni_ipamd_startup_duration_seconds, the whole latency during IPAMD startupawscni_ipamd_startup_aws_duration_secondsthe latency, the latency majorly from aws side duringipamd.New()awscni_aws_api_latency_msTesting done on this change:
deployed and tested in prom and grafana
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.