Open
Conversation
Reduce log noise by changing Infof to Debugf for routine IP address add and reconciliation messages in the datastore and IPAMD paths. These logs create unnecessary noise during normal operation.
There was a problem hiding this comment.
Pull request overview
This PR reduces production log noise in the IPAMD reconciliation and datastore paths by demoting routine “steady-state” IP reconciliation messages from info to debug.
Changes:
- Demoted “skip primary IP” and “trying to add IP” reconciliation logs in
verifyAndAddIPsToDatastoretoDebugf. - Demoted datastore “adding CIDR” entry log and “IP already in DS” steady-state log to
Debugf.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/ipamd/ipamd.go | Lowers verbosity for routine IP reconciliation logs during ENI IP pool reconciliation. |
| pkg/ipamd/datastore/data_store.go | Lowers verbosity for datastore add/duplicate IP logs while keeping success/failure logs at higher levels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
cleanup
What does this PR do / Why do we need it?:
Reduces log noise by changing level from info to debug for routine IP address add and reconciliation messages in the datastore and IPAMD paths.
This is with no incidents and under routine operation. Changed log lines and why:
"Trying to add %s"-> pre-action intent log, outcome already logged on failure and on success"Reconcile and skip primary IP"-> logs an immutable invariant, the primary IP is always skipped"Adding %s to DS for %s"-> function-entry trace, outcome already logged by downstream branches"IP already in DS"-> confirms nothing changed, the expected steady-state outcome on 99.9% of callsOverall these logs don't increase visibility and serve little purpose in production. Some of these generate
Nodes × Secondary IPs × 2 linesevery minute.Testing done on this change:
N/A
Will this PR introduce any new dependencies?:
No.
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No.
Does this change require updates to the CNI daemonset config files to work?:
No.
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.