Skip to content

Demote verbose IP logs to debug #3607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayberk wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

Demote verbose IP logs to debug #3607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/ipamd/datastore/data_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ func (ds *DataStore) AddIPv4CidrToStore(eniID string, ipv4Cidr net.IPNet, isPref
defer ds.lock.Unlock()

strIPv4Cidr := ipv4Cidr.String()
ds.log.Infof("Adding %s to DS for %s", strIPv4Cidr, eniID)
ds.log.Debugf("Adding %s to DS for %s", strIPv4Cidr, eniID)
curENI, ok := ds.eniPool[eniID]
if !ok {
ds.log.Infof("unknown ENI")
Expand All @@ -541,7 +541,7 @@ func (ds *DataStore) AddIPv4CidrToStore(eniID string, ipv4Cidr net.IPNet, isPref
// Already there
_, ok = curENI.AvailableIPv4Cidrs[strIPv4Cidr]
if ok {
ds.log.Infof("IP already in DS")
ds.log.Debugf("IP already in DS")
return errors.New(IPAlreadyInStoreError)
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/ipamd/ipamd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1810,7 +1810,7 @@ func (c *IPAMContext) verifyAndAddIPsToDatastore(ctx context.Context, eni string
for _, privateIPv4 := range attachedENIIPs {
strPrivateIPv4 := aws.ToString(privateIPv4.PrivateIpAddress)
if strPrivateIPv4 == c.primaryIP[eni] {
log.Infof("Reconcile and skip primary IP %s on ENI %s", strPrivateIPv4, eni)
log.Debugf("Reconcile and skip primary IP %s on ENI %s", strPrivateIPv4, eni)
continue
}

Expand Down Expand Up @@ -1856,7 +1856,7 @@ func (c *IPAMContext) verifyAndAddIPsToDatastore(ctx context.Context, eni string
c.reconcileCooldownCache.Remove(strPrivateIPv4)
}
}
log.Infof("Trying to add %s", strPrivateIPv4)
log.Debugf("Trying to add %s", strPrivateIPv4)
// Try to add the IP
err := c.dataStoreAccess.GetDataStore(networkCard).AddIPv4CidrToStore(eni, ipv4Addr, false)
if err != nil && err.Error() != datastore.IPAlreadyInStoreError {
Expand Down
Loading