-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(applicationsignals-alpha): introduce Application Signals SLO L2 constructs #34413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
TejeshreeDaliVenugopal
wants to merge
18
commits into
aws:main
from
TejeshreeDaliVenugopal:dalivete-dev/application-signals-slo
+1,498
−0
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
467d2a6
Add application signals enablement L2
bjrara 9516a5b
Address comments
bjrara a314a29
Update daemon test
bjrara 22fad49
Address additional comments
bjrara 4acf1ef
feat: Add L2 CDK for application-signals-slo
liunia-amazon 3ffca9e
Improve interface definition and add more default values
liunia-amazon 588dc02
update keyAttributes and add unit tests
TejeshreeDaliVenugopal 015af7f
Merge branch 'main' into dalivete-dev/application-signals-slo
moelasmar 60bec35
Delete packages/@aws-cdk/aws-applicationsignals-alpha/test/integ.ecs-…
moelasmar c5904e9
Delete packages/@aws-cdk/aws-applicationsignals-alpha/test/integ.ecs-…
moelasmar 95ff88e
Delete packages/@aws-cdk/aws-applicationsignals-alpha/test/integ.ecs-…
moelasmar 2c7cc85
Delete packages/@aws-cdk/aws-applicationsignals-alpha/test/integ.ecs-…
moelasmar 82f93d3
Delete packages/@aws-cdk/aws-applicationsignals-alpha/test/integ.ecs-…
moelasmar c928a78
Delete packages/@aws-cdk/aws-applicationsignals-alpha/test/integ.ecs-…
moelasmar 5c18ee9
Delete packages/@aws-cdk/aws-applicationsignals-alpha/test/integ.ecs-…
moelasmar 27c51ef
Delete packages/@aws-cdk/aws-applicationsignals-alpha/test/integ.ecs-…
moelasmar 10f503a
Delete packages/@aws-cdk/aws-applicationsignals-alpha/test/integ.ecs-…
moelasmar 6a59aff
Delete packages/@aws-cdk/aws-applicationsignals-alpha/test/integ.ecs-…
moelasmar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
162 changes: 162 additions & 0 deletions
162
packages/@aws-cdk/aws-applicationsignals-alpha/lib/slo/constants.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,162 @@ | ||
/** | ||
* Types of metrics that can be used for SLIs | ||
*/ | ||
export enum MetricType { | ||
/** | ||
* Latency-based metric type | ||
* Used for measuring response time or duration | ||
*/ | ||
LATENCY = 'LATENCY', | ||
|
||
/** | ||
* Availability-based metric type | ||
* Used for measuring uptime or success rate | ||
*/ | ||
AVAILABILITY = 'AVAILABILITY' | ||
} | ||
|
||
/** | ||
* Default values for goal configuration | ||
*/ | ||
export const DEFAULT_GOAL_CONFIG = { | ||
ATTAINMENT_GOAL: 99.9, | ||
WARNING_THRESHOLD: 30, | ||
} as const; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Either move these constants as static properties in some class and it is better to be the classes where these values be used, or make them private. Do we need to add these values in CDK Docs, and let the customers use them? |
||
|
||
/** | ||
* Comparison operators for metric thresholds | ||
*/ | ||
export enum ComparisonOperator { | ||
/** | ||
* Greater than operator | ||
* True if metric value is strictly greater than threshold | ||
*/ | ||
GREATER_THAN = 'GREATER_THAN', | ||
|
||
/** | ||
* Less than operator | ||
* True if metric value is strictly less than threshold | ||
*/ | ||
LESS_THAN = 'LESS_THAN', | ||
|
||
/** | ||
* Greater than or equal operator | ||
* True if metric value is greater than or equal to threshold | ||
*/ | ||
GREATER_THAN_OR_EQUAL = 'GREATER_THAN_OR_EQUAL', | ||
|
||
/** | ||
* Less than or equal operator | ||
* True if metric value is less than or equal to threshold | ||
*/ | ||
LESS_THAN_OR_EQUAL = 'LESS_THAN_OR_EQUAL' | ||
} | ||
|
||
/** | ||
* Statistical methods for aggregating metric values | ||
*/ | ||
export enum MetricStatistic { | ||
/** | ||
* Average of all values in the period | ||
*/ | ||
AVERAGE = 'Average', | ||
|
||
/** | ||
* Sum of all values in the period | ||
*/ | ||
SUM = 'Sum', | ||
|
||
/** | ||
* Minimum value in the period | ||
*/ | ||
MINIMUM = 'Minimum', | ||
|
||
/** | ||
* Maximum value in the period | ||
*/ | ||
MAXIMUM = 'Maximum', | ||
|
||
/** | ||
* Count of samples in the period | ||
*/ | ||
SAMPLE_COUNT = 'SampleCount', | ||
|
||
/** | ||
* 99th percentile of values in the period | ||
*/ | ||
P99 = 'p99', | ||
|
||
/** | ||
* 95th percentile of values in the period | ||
*/ | ||
P95 = 'p95', | ||
|
||
/** | ||
* 90th percentile of values in the period | ||
*/ | ||
P90 = 'p90', | ||
|
||
/** | ||
* 50th percentile (median) of values in the period | ||
*/ | ||
P50 = 'p50' | ||
} | ||
|
||
/** | ||
* Types of services that can be monitored | ||
*/ | ||
export enum KeyAttributeType { | ||
/** | ||
* Service running in your account | ||
*/ | ||
SERVICE = 'SERVICE', | ||
|
||
/** | ||
* AWS managed service | ||
*/ | ||
AWS_SERVICE = 'AWS_SERVICE', | ||
|
||
/** | ||
* External service | ||
*/ | ||
REMOTE_SERVICE = 'REMOTE_SERVICE', | ||
|
||
/** | ||
* Resource | ||
*/ | ||
|
||
RESOURCE = 'RESOURCE', | ||
|
||
/** | ||
* AWS managed Resource | ||
*/ | ||
|
||
AWS_RESOURCE = 'AWS::RESOURCE' | ||
|
||
} | ||
|
||
/** | ||
* Units for duration measurement in SLO intervals | ||
*/ | ||
export enum DurationUnit { | ||
/** | ||
* Minute unit for fine-grained intervals | ||
*/ | ||
MINUTE = 'MINUTE', | ||
|
||
/** | ||
* Hour unit for medium-term intervals | ||
*/ | ||
HOUR = 'HOUR', | ||
|
||
/** | ||
* Day unit for daily intervals | ||
*/ | ||
DAY = 'DAY', | ||
|
||
/** | ||
* Month unit for long-term intervals | ||
* Used for calendar-aligned monitoring | ||
*/ | ||
MONTH = 'MONTH' | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an index.ts in the slo dir, and expose whatever you want there. Here, add only the directory.