fix(dotnet): simplify build tool lookup#835
Open
sriram-mv wants to merge 1 commit intoaws:developfrom
Open
Conversation
github-actions
bot
added
pr/external
stage/needs-triage
reedham-aws
requested changes
Feb 19, 2026
| self.subprocess_dotnet.run.assert_any_call( | ||
| ["tool", "update", "-g", "Amazon.Lambda.Tools", "--ignore-failed-sources"] | ||
| ) | ||
| self.subprocess_dotnet.run.assert_called_once_with(["tool", "list", "-g"]) |
Contributor
There was a problem hiding this comment.
Should we also assert below this that the actual install is not done?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#347
Description of changes
Simplify check to purely check for existence of the tool and not attempt to install it every time. If it doesnt exist, install it. The global installation action's lifecycle is a build command which terminates, so its not saved anywhere. I think this is cleaner.
Description of how you validated changes
Unit tests work.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.