Skip to content

[Release-3.14.1][E2E Test] Skip dcv installation when test_build_image on Ubuntu #7164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hehe7318 wants to merge 3 commits into
base: release-3.14
Choose a base branch
from
Open

[Release-3.14.1][E2E Test] Skip dcv installation when test_build_image on Ubuntu #7164

hehe7318 wants to merge 3 commits into from
+10 −0

Conversation

@hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Dec 19, 2025

Description of changes

  • Skip dcv installation when test_build_image on Ubuntu

Tests

  • Running

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hehe7318 hehe7318 requested review from a team as code owners December 19, 2025 21:59
@hehe7318 hehe7318 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Dec 19, 2025
gmarciani
gmarciani reviewed Dec 19, 2025
View reviewed changes
tests/integration-tests/tests/createami/test_createami.py Outdated

# Disable DCV installation for Ubuntu
# TODO: When the Ubuntu DCV issue resolved, remove this line.
enable_dcv = "ubuntu" not in os
Copy link
Contributor

@gmarciani gmarciani Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue occurs only on ubuntu 24.04 and majority of the times in DLAMI Ubu 24.04, not even the vanilla flavor. Can we limit this test case to ubuntu24.04?

Copy link
Contributor Author

@hehe7318 hehe7318 Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmarciani gmarciani gmarciani left review comments

@himani2411 himani2411 himani2411 approved these changes

Assignees

No one assigned

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hehe7318 @gmarciani @himani2411