Skip to content

[Release-3.14.1][E2E Test] Skip dcv installation when test_build_image on Ubuntu #7164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hehe7318 wants to merge 3 commits into
base: release-3.14
Choose a base branch
from
Open

[Release-3.14.1][E2E Test] Skip dcv installation when test_build_image on Ubuntu #7164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec78efc
Skip dcv installation when test_build_image on Ubuntu
hehe7318 Dec 19, 2025
0d21097
Limit this test case to ubuntu24.04
hehe7318 Dec 19, 2025
ccfe4e9
Merge branch 'release-3.14' into wip/skip-dcv-install-in-ubuntu-when-…
hehe7318 Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/integration-tests/tests/createami/test_createami.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,10 @@ def test_build_image(
enable_lustre_client = False
if os in ["alinux2", "alinux2023", "rocky9"]:
update_os_packages = True

# Disable DCV installation for Ubuntu 24.04 to avoid build failures with DLAMI
enable_dcv = os != "ubuntu2404"

image_config = pcluster_config_reader(
config_file="image.config.yaml",
parent_image=base_ami,
Expand All @@ -165,6 +169,7 @@ def test_build_image(
enable_nvidia=str(enable_nvidia and get_gpu_count(instance) > 0).lower(),
update_os_packages=str(update_os_packages).lower(),
enable_lustre_client=str(enable_lustre_client).lower(),
enable_dcv=str(enable_dcv).lower(),
)

image = images_factory(image_id, image_config, region)
Expand Down
5 changes: 5 additions & 0 deletions tests/integration-tests/tests/createami/test_createami/test_build_image/image.config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,8 @@ DeploymentSettings:
- {{ default_vpc_security_group_id }}
DevSettings:
TerminateInstanceOnFailure: True
{% if enable_dcv == "false" %}
Cookbook:
ExtraChefAttributes: |
{"cluster": {"dcv": {"install_enabled": false}}}
{% endif %}
Loading