Skip to content

Conversation

@sp1999
Copy link
Member

@sp1999 sp1999 commented Nov 8, 2025

Description of changes:
This PR comments out the unused imports.

Testing:

make build-all-test-binaries

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sp1999 sp1999 changed the title Comment out unused imports [release-0.24] Comment out unused imports Nov 8, 2025
@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2025
@sp1999
Copy link
Member Author

sp1999 commented Nov 8, 2025

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-0.24@19da6cc). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.24   #10345   +/-   ##
===============================================
  Coverage                ?   70.00%           
===============================================
  Files                   ?      680           
  Lines                   ?    41751           
  Branches                ?        0           
===============================================
  Hits                    ?    29229           
  Misses                  ?    10724           
  Partials                ?     1798           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eks-distro-bot eks-distro-bot merged commit a40ab36 into aws:release-0.24 Nov 8, 2025
11 checks passed
@sp1999 sp1999 deleted the comment-out-unused-imports branch November 8, 2025 04:19
sp1999 added a commit to sp1999/eks-anywhere that referenced this pull request Nov 8, 2025
sp1999 added a commit that referenced this pull request Nov 8, 2025
* Revert "Comment out unused imports (#10345)"

This reverts commit a40ab36.

* Revert "Comment out all the non-packages tests temporarily to speed up the curated packages testing for the release (#10344)"

This reverts commit 19da6cc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants