-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): MEMORY_LIMIT env for custom controller container name #7700
fix(helm): MEMORY_LIMIT env for custom controller container name #7700
Conversation
Signed-off-by: flavono123 <[email protected]>
Signed-off-by: flavono123 <[email protected]>
✅ Deploy Preview for karpenter-docs-prod canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Pull Request Test Coverage Report for Build 13194524531Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
…#7700) Signed-off-by: flavono123 <[email protected]>
Fixes #7650
Description
the value
controller.containerName
is supported #7384, but not for relevant env set by downward api.controller.containerName
if setHow was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.