Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Bottlerocket FIPS AMIs #7756

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aufomin
Copy link

@aufomin aufomin commented Feb 20, 2025

Fixes #N/A

Description
This pull request adds support for Bottlerocket FIPS AMIs in the AWS provider for Karpenter. It introduces logic to detect and use FIPS-compliant AMIs when specified in the configuration.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aufomin aufomin requested a review from a team as a code owner February 20, 2025 14:59
@aufomin aufomin requested a review from tzneal February 20, 2025 14:59
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 2915998
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67bc6ad19d62d00008344223
😎 Deploy Preview https://deploy-preview-7756--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aufomin aufomin force-pushed the feat/update-bottlerocket-fips-support branch from 69538a8 to e421679 Compare February 20, 2025 15:41
@rschalo
Copy link
Contributor

rschalo commented Feb 20, 2025

Thanks for the PR. Do FIPS AMIs work when not using FIPS endpoints? Have you had a chance to already test this in a dev environment?

@aufomin
Copy link
Author

aufomin commented Feb 20, 2025

I haven’t tested this in a dev environment yet. I’m not entirely sure about the behavior of FIPS AMIs when not using FIPS endpoints.

@aufomin aufomin requested a review from rschalo February 20, 2025 23:30
@aufomin aufomin force-pushed the feat/update-bottlerocket-fips-support branch 7 times, most recently from 335349b to 44ca97b Compare February 21, 2025 00:23
@aufomin aufomin force-pushed the feat/update-bottlerocket-fips-support branch 6 times, most recently from 8a11599 to 2915998 Compare February 24, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants