Conversation
added 3 commits
December 15, 2025 13:46
TingDaoK
reviewed
Dec 19, 2025
| #ifndef __APPLE__ /* Server side ALPN doesn't work for MacOS */ | ||
| // TODO: Investigate further and fix behavior taking into account the recent migration | ||
| // to newer Apple Netowrk Frameowrk on aws-c-io. Implemented temporary fix for CI tests. | ||
| // CI fails on local for some machines. Still under investigation. |
Contributor
There was a problem hiding this comment.
why not put the notes of what we found yesterday here?
TingDaoK
reviewed
Dec 19, 2025
| add_test_case(test_no_proxy_invalid_host_inputs) | ||
|
|
||
| add_test_case(http_tunnel_proxy_connection_success) | ||
| if(NOT APPLE) |
Contributor
There was a problem hiding this comment.
skip from CMakeList will be hard to notice.
do something similar to
TEST_CASE(multipart_upload_with_network_interface_names_mock_server) {
(void)ctx;
#if defined(AWS_OS_WINDOWS) || defined(AWS_OS_APPLE)
(void)allocator;
return AWS_OP_SKIP;
#else
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 79.69% 79.68% -0.02%
==========================================
Files 28 28
Lines 11866 11865 -1
==========================================
- Hits 9457 9455 -2
- Misses 2409 2410 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TingDaoK
approved these changes
Dec 19, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.