Skip to content

Fix CI issues #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azkrishpy merged 4 commits into from
Dec 19, 2025
Merged

Fix CI issues #538

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fea6210
workflow updates
Dec 15, 2025
0d53e1f
temp fix for ci
Dec 16, 2025
6c7e6e6
more fixes
Dec 19, 2025
24176f4
address comments
Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,6 @@ jobs:
runs-on: macos-14
strategy:
fail-fast: false
matrix:
eventloop: ["kqueue", "dispatch_queue"]
steps:
- uses: aws-actions/configure-aws-credentials@v4
with:
Expand Down Expand Up @@ -250,8 +248,6 @@ jobs:
runs-on: macos-14
strategy:
fail-fast: false
matrix:
eventloop: ["kqueue", "dispatch_queue"]
steps:
- uses: aws-actions/configure-aws-credentials@v4
with:
Expand Down
2 changes: 2 additions & 0 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,9 @@ add_test_case(test_no_proxy_invalid_patterns)
add_test_case(test_no_proxy_invalid_host_inputs)

add_test_case(http_tunnel_proxy_connection_success)
if(NOT APPLE)
Copy link
Copy Markdown
Contributor

@TingDaoK TingDaoK Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip from CMakeList will be hard to notice.
do something similar to

TEST_CASE(multipart_upload_with_network_interface_names_mock_server) {
    (void)ctx;
#if defined(AWS_OS_WINDOWS) || defined(AWS_OS_APPLE)
    (void)allocator;
    return AWS_OP_SKIP;
#else

add_test_case(https_tunnel_proxy_connection_success)
endif()
add_test_case(http_tunnel_proxy_connection_failure_connect)
add_test_case(https_tunnel_proxy_connection_failure_connect)
add_test_case(https_tunnel_proxy_connection_failure_tls)
Expand Down
12 changes: 8 additions & 4 deletions tests/test_connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,14 +735,18 @@ static int s_test_connection_customized_alpn_error_with_unknown_return_string(
tester.wait_client_connection_num = 1;
tester.wait_server_connection_num = 1;

#ifndef __APPLE__ /* Server side ALPN doesn't work for MacOS */
// TODO: Investigate further and fix behavior taking into account the recent migration
// to newer Apple Netowrk Frameowrk on aws-c-io. Implemented temporary fix for CI tests.
// CI fails on local for some machines. Still under investigation.
Copy link
Copy Markdown
Contributor

@TingDaoK TingDaoK Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not put the notes of what we found yesterday here?


// #ifndef __APPLE__ /* Server side ALPN doesn't work for MacOS */
ASSERT_FAILS(s_tester_wait(&tester, s_tester_connection_setup_pred));
/* Assert that we have the negotiated protocol and error returned from callback */
ASSERT_TRUE(aws_byte_buf_eq_c_str(&tester.negotiated_protocol, customized_alpn_string));
ASSERT_INT_EQUALS(aws_last_error(), AWS_ERROR_HTTP_UNSUPPORTED_PROTOCOL);
#else
ASSERT_SUCCESS(s_tester_wait(&tester, s_tester_connection_setup_pred));
#endif
// #else
// ASSERT_SUCCESS(s_tester_wait(&tester, s_tester_connection_setup_pred));
// #endif
/* clean up */
release_all_client_connections(&tester);
release_all_server_connections(&tester);
Expand Down
3 changes: 3 additions & 0 deletions tests/test_proxy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,9 @@ AWS_TEST_CASE(
/*
* For tls-enabled tunneling proxy connections:
* Test the happy path by verifying CONNECT request, tls upgrade attempt
* TODO: This test is temporarily disabled on Apple platforms following a breaking change
* due to migration to the new Apple Network Framework. Investigations underway for rethinking
* proxy implementation on Apple platforms. Test should be re-enabled post-fix on CMakeLists.txt.
*/
static int s_test_https_tunnel_proxy_connection_success(struct aws_allocator *allocator, void *ctx) {
(void)ctx;
Expand Down
Loading