Update CRT submodules to latest releases by passaro · Pull Request #1458 · awslabs/mountpoint-s3

passaro · 2025-06-08T11:00:26Z

Note

This PR reapplies the changes in #1430, previously reverted in #1435, with the addition of a fix to a race condition in aws-c-s3 (awslabs/aws-c-s3#521).

In particular, we pick up - but do not adopt in this change - the new Memory pool interface
(awslabs/aws-c-s3#517), which requires minor adjustments to the bindings and the poll_buffer_pool_usage_stats function.

Full CRT changelog:

Submodule mountpoint-s3-crt-sys/crt/aws-c-cal fa108de5..938d0fea:
  > [FIX] heap use after free on aws_ecc_key_pair_new_from_asn1 (#219)
  > Remove clang-3 from CI (#218)
  > Fix casing on Windows header files (#217)
  > dlopen(NULL) returns NULL on static linked executable (#215)
Submodule mountpoint-s3-crt-sys/crt/aws-c-common 8ae8f48e..aaa2f11e:
  > Fix invalid XML Buffer Overflow Error (#1201)
  > Add aws_cbor_decoder_reset_src api for aws_cbor_decoder (#1202)
  > Fix casing on Windows header files (#1199)
  > Error handling docs (#1197)
  > make exports consistent (#1196)
Submodule mountpoint-s3-crt-sys/crt/aws-c-http ca7e0e29..3eedf1ef:
  > fix mock server window update on 0 length body (#517)
Submodule mountpoint-s3-crt-sys/crt/aws-c-io 8286c781..689dee3c:
  > Fix warnings in iOS Cross Compile CI (#733)
  > Remove clang-3 from CI (#731)
  > Acquire/Release Event Loop (#725)
  > Fix casing on Windows header files (#730)
Submodule mountpoint-s3-crt-sys/crt/aws-c-s3 7d2d4b30..52c90d39:
  > Fix race condition between mem acquire and cancel (#521)
  > Memory pool interface (#517)
  > Remove clang-3 from CI (#520)
  > Revert "[s3_meta_request]: Retry on ExpiredToken" (#518)
Submodule mountpoint-s3-crt-sys/crt/aws-c-sdkutils ba6a28fa..f678bda9:
  > Fix double free on malformed rulesets (#53)
  > make exports consistent (#52)

Does this change impact existing behavior?

No change in behavior.

Does this change need a changelog entry? Does it require a version change?

Yes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin
(DCO).

Update the CRT libraries to the latest releases. In particular, we pick up - but do not adopt in this change - the new Memory pool interface ([awslabs/aws-c-s3#517](awslabs/aws-c-s3#517)), which requires minor adjustments to the bindings and the `poll_buffer_pool_usage_stats` function. <details> <summary>Full CRT changelog:</summary> ``` Submodule mountpoint-s3-crt-sys/crt/aws-c-cal fa108de5..938d0fea: > [FIX] heap use after free on aws_ecc_key_pair_new_from_asn1 (awslabs#219) > Remove clang-3 from CI (awslabs#218) > Fix casing on Windows header files (awslabs#217) > dlopen(NULL) returns NULL on static linked executable (awslabs#215) Submodule mountpoint-s3-crt-sys/crt/aws-c-common 8ae8f48e..aaa2f11e: > Fix invalid XML Buffer Overflow Error (awslabs#1201) > Add aws_cbor_decoder_reset_src api for aws_cbor_decoder (awslabs#1202) > Fix casing on Windows header files (awslabs#1199) > Error handling docs (awslabs#1197) > make exports consistent (awslabs#1196) Submodule mountpoint-s3-crt-sys/crt/aws-c-http ca7e0e29..3eedf1ef: > fix mock server window update on 0 length body (awslabs#517) Submodule mountpoint-s3-crt-sys/crt/aws-c-io 8286c781..689dee3c: > Fix warnings in iOS Cross Compile CI (awslabs#733) > Remove clang-3 from CI (awslabs#731) > Acquire/Release Event Loop (awslabs#725) > Fix casing on Windows header files (awslabs#730) Submodule mountpoint-s3-crt-sys/crt/aws-c-s3 7d2d4b30..52c90d39: > Fix race condition between mem acquire and cancel (awslabs#521) > Memory pool interface (awslabs#517) > Remove clang-3 from CI (awslabs#520) > Revert "[s3_meta_request]: Retry on ExpiredToken" (awslabs#518) Submodule mountpoint-s3-crt-sys/crt/aws-c-sdkutils ba6a28fa..f678bda9: > Fix double free on malformed rulesets (awslabs#53) > make exports consistent (awslabs#52) ``` </details> ### Does this change impact existing behavior? No change in behavior. ### Does this change need a changelog entry? Does it require a version change? Yes. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

dannycjones · 2025-06-09T12:42:07Z

mountpoint-s3-crt-sys/CHANGELOG.md

+## Unreleased (v0.14.0)
+
+* Update to latest CRT dependencies.
+* Include bindings for the new `s3_buffer_pool` API in `aws-c-s3`. ([#1430](https://github.com/awslabs/mountpoint-s3/pull/1430))


The PR link needs updating

dannycjones · 2025-06-09T12:47:06Z

mountpoint-s3/CHANGELOG.md

-## Unreleased
+## Unreleased (v1.18.1)
+
+* Update underlying S3 client version.


Should we drop this with the next change to Mountpoint? I'm not sure we really want these entries in this change log.

Oops, shouldn't have approved, only commented

Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

This reverts commit f138efc. Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

This reverts commit f138efc. As part of the investigation on the benchmark failures in the CI, e.g. https://github.com/awslabs/mountpoint-s3/actions/runs/15625094824/job/44017689830, we are reverting to the previous CRT releases. ### Does this change impact existing behavior? No. ### Does this change need a changelog entry? Does it require a version change? Yes, reverted. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

…slabs#1466) This reverts commit 1ee3d8f.

> [!NOTE] > This PR reapplies the changes in awslabs#1430, previously reverted in awslabs#1435, with the addition of a fix to a race condition in `aws-c-s3` (awslabs/aws-c-s3#521). In particular, we pick up - but do not adopt in this change - the new Memory pool interface ([awslabs/aws-c-s3#517](awslabs/aws-c-s3#517)), which requires minor adjustments to the bindings and the `poll_buffer_pool_usage_stats` function. <details> <summary>Full CRT changelog:</summary> ``` Submodule mountpoint-s3-crt-sys/crt/aws-c-cal fa108de5..938d0fea: > [FIX] heap use after free on aws_ecc_key_pair_new_from_asn1 (awslabs#219) > Remove clang-3 from CI (awslabs#218) > Fix casing on Windows header files (awslabs#217) > dlopen(NULL) returns NULL on static linked executable (awslabs#215) Submodule mountpoint-s3-crt-sys/crt/aws-c-common 8ae8f48e..aaa2f11e: > Fix invalid XML Buffer Overflow Error (awslabs#1201) > Add aws_cbor_decoder_reset_src api for aws_cbor_decoder (awslabs#1202) > Fix casing on Windows header files (awslabs#1199) > Error handling docs (awslabs#1197) > make exports consistent (awslabs#1196) Submodule mountpoint-s3-crt-sys/crt/aws-c-http ca7e0e29..3eedf1ef: > fix mock server window update on 0 length body (awslabs#517) Submodule mountpoint-s3-crt-sys/crt/aws-c-io 8286c781..689dee3c: > Fix warnings in iOS Cross Compile CI (awslabs#733) > Remove clang-3 from CI (awslabs#731) > Acquire/Release Event Loop (awslabs#725) > Fix casing on Windows header files (awslabs#730) Submodule mountpoint-s3-crt-sys/crt/aws-c-s3 7d2d4b30..52c90d39: > Fix race condition between mem acquire and cancel (awslabs#521) > Memory pool interface (awslabs#517) > Remove clang-3 from CI (awslabs#520) > Revert "[s3_meta_request]: Retry on ExpiredToken" (awslabs#518) Submodule mountpoint-s3-crt-sys/crt/aws-c-sdkutils ba6a28fa..f678bda9: > Fix double free on malformed rulesets (awslabs#53) > make exports consistent (awslabs#52) ``` </details> ### Does this change impact existing behavior? No change in behavior. ### Does this change need a changelog entry? Does it require a version change? Yes. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

…labs#1466) This reverts commit f138efc. As part of the investigation on the benchmark failures in the CI, e.g. https://github.com/awslabs/mountpoint-s3/actions/runs/15625094824/job/44017689830, we are reverting to the previous CRT releases. ### Does this change impact existing behavior? No. ### Does this change need a changelog entry? Does it require a version change? Yes, reverted. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

> [!NOTE] > This PR reapplies the changes in awslabs#1430, previously reverted in awslabs#1435, with the addition of a fix to a race condition in `aws-c-s3` (awslabs/aws-c-s3#521). In particular, we pick up - but do not adopt in this change - the new Memory pool interface ([awslabs/aws-c-s3#517](awslabs/aws-c-s3#517)), which requires minor adjustments to the bindings and the `poll_buffer_pool_usage_stats` function. <details> <summary>Full CRT changelog:</summary> ``` Submodule mountpoint-s3-crt-sys/crt/aws-c-cal fa108de5..938d0fea: > [FIX] heap use after free on aws_ecc_key_pair_new_from_asn1 (awslabs#219) > Remove clang-3 from CI (awslabs#218) > Fix casing on Windows header files (awslabs#217) > dlopen(NULL) returns NULL on static linked executable (awslabs#215) Submodule mountpoint-s3-crt-sys/crt/aws-c-common 8ae8f48e..aaa2f11e: > Fix invalid XML Buffer Overflow Error (awslabs#1201) > Add aws_cbor_decoder_reset_src api for aws_cbor_decoder (awslabs#1202) > Fix casing on Windows header files (awslabs#1199) > Error handling docs (awslabs#1197) > make exports consistent (awslabs#1196) Submodule mountpoint-s3-crt-sys/crt/aws-c-http ca7e0e29..3eedf1ef: > fix mock server window update on 0 length body (awslabs#517) Submodule mountpoint-s3-crt-sys/crt/aws-c-io 8286c781..689dee3c: > Fix warnings in iOS Cross Compile CI (awslabs#733) > Remove clang-3 from CI (awslabs#731) > Acquire/Release Event Loop (awslabs#725) > Fix casing on Windows header files (awslabs#730) Submodule mountpoint-s3-crt-sys/crt/aws-c-s3 7d2d4b30..52c90d39: > Fix race condition between mem acquire and cancel (awslabs#521) > Memory pool interface (awslabs#517) > Remove clang-3 from CI (awslabs#520) > Revert "[s3_meta_request]: Retry on ExpiredToken" (awslabs#518) Submodule mountpoint-s3-crt-sys/crt/aws-c-sdkutils ba6a28fa..f678bda9: > Fix double free on malformed rulesets (awslabs#53) > make exports consistent (awslabs#52) ``` </details> ### Does this change impact existing behavior? No change in behavior. ### Does this change need a changelog entry? Does it require a version change? Yes. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

…labs#1466) This reverts commit f138efc. As part of the investigation on the benchmark failures in the CI, e.g. https://github.com/awslabs/mountpoint-s3/actions/runs/15625094824/job/44017689830, we are reverting to the previous CRT releases. ### Does this change impact existing behavior? No. ### Does this change need a changelog entry? Does it require a version change? Yes, reverted. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

passaro added the performance PRs to run benchmarks on label Jun 8, 2025

passaro had a problem deploying to PR benchmarks June 8, 2025 11:00 — with GitHub Actions Failure

passaro temporarily deployed to PR integration tests June 8, 2025 11:00 — with GitHub Actions Inactive

passaro had a problem deploying to PR benchmarks June 8, 2025 11:00 — with GitHub Actions Failure

passaro temporarily deployed to PR integration tests June 8, 2025 11:00 — with GitHub Actions Inactive

passaro temporarily deployed to PR benchmarks June 8, 2025 11:00 — with GitHub Actions Inactive

passaro temporarily deployed to PR integration tests June 8, 2025 11:00 — with GitHub Actions Inactive

passaro had a problem deploying to PR benchmarks June 8, 2025 11:00 — with GitHub Actions Failure

passaro temporarily deployed to PR benchmarks June 8, 2025 11:00 — with GitHub Actions Inactive

passaro temporarily deployed to PR benchmarks June 8, 2025 13:48 — with GitHub Actions Inactive

passaro marked this pull request as ready for review June 8, 2025 18:22

dannycjones previously approved these changes Jun 9, 2025

View reviewed changes

Fix PR # in changelog

43aa231

Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

passaro removed the performance PRs to run benchmarks on label Jun 9, 2025

passaro temporarily deployed to PR integration tests June 9, 2025 15:34 — with GitHub Actions Inactive

passaro enabled auto-merge June 9, 2025 15:35

dannycjones approved these changes Jun 9, 2025

View reviewed changes

passaro added this pull request to the merge queue Jun 9, 2025

Merged via the queue into awslabs:main with commit f138efc Jun 9, 2025
28 checks passed

passaro deleted the mem/crt-update branch June 9, 2025 16:06

passaro added a commit to passaro/mountpoint-s3 that referenced this pull request Jun 13, 2025

Revert "Update CRT submodules to latest releases (awslabs#1458)"

4f8a60e

This reverts commit f138efc. Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

passaro added a commit to passaro/mountpoint-s3 that referenced this pull request Jun 16, 2025

Reapply "Update CRT submodules to latest releases (awslabs#1458)" (aw…

3e6bb0b

…slabs#1466) This reverts commit 1ee3d8f.

passaro added a commit to passaro/mountpoint-s3 that referenced this pull request Jun 19, 2025

Reapply "Update CRT submodules to latest releases (awslabs#1458)" (aw…

3cdbfa9

…slabs#1466) This reverts commit 1ee3d8f.

c-hagem pushed a commit to c-hagem/mountpoint-s3 that referenced this pull request Jun 20, 2025

Reapply "Update CRT submodules to latest releases (awslabs#1458)" (aw…

e70bb91

…slabs#1466) This reverts commit 1ee3d8f.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CRT submodules to latest releases#1458

Update CRT submodules to latest releases#1458
passaro merged 2 commits intoawslabs:mainfrom
passaro:mem/crt-update

passaro commented Jun 8, 2025

Uh oh!

dannycjones Jun 9, 2025

Uh oh!

dannycjones Jun 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

passaro commented Jun 8, 2025

Does this change impact existing behavior?

Does this change need a changelog entry? Does it require a version change?

Uh oh!

dannycjones Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

dannycjones Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants