Add Human Cell Atlas to ODP registry #2667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannes-ucsc
force-pushed
the
main
branch
2 times, most recently
from
360bc5a to
0f990c7
Compare
Contributor
|
@hannes-ucsc, try to change the resource type to "S3 Bucket" instead of "S3 bucket". The build is checking against the resources.yaml file. |
Contributor
|
Make sure your links in explore match the regular expression: explore_regex = re.compile(r"^[.+](https?://[\w\d.-/#?&%=]+)$"). Check datasets/amazon-berkeley-objects.yaml for examples on how to do this. |
Contributor
Author
|
There may be backslashes missing in the regex you posted but I think I understand what the intent is: These links are Markdown, not bare URLs. |
Contributor
|
@hannes-ucsc can you update the branch so it is up to date with the main branch please? |
Contributor
|
Also, @hannes-ucsc please add the "life sciences" tag, this helps us track all our LS datasets. |
Contributor
Author
|
@berylrab, both done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add Human Cell Atlas.
Logo is https://www.humancellatlas.org/wp-content/themes/new_human_cell_atlas/dist/assets/img/logo-hca.png
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.