Skip to content

[Closed] Add standalone convert mode for SOCI index creation without containerd#1864

Closed
prafgup wants to merge 1 commit into
awslabs:mainfrom
prafgup:main
Closed

[Closed] Add standalone convert mode for SOCI index creation without containerd#1864
prafgup wants to merge 1 commit into
awslabs:mainfrom
prafgup:main

Conversation

@prafgup
Copy link
Copy Markdown
Contributor

@prafgup prafgup commented Feb 16, 2026

New PR - #1870

@prafgup prafgup marked this pull request as ready for review February 16, 2026 17:14
@prafgup prafgup requested a review from a team as a code owner February 16, 2026 17:14
Comment thread cmd/soci/commands/internal/standalone.go Outdated
Comment thread cmd/soci/commands/internal/standalone.go Outdated
Comment thread cmd/soci/commands/internal/standalone.go Outdated
Comment thread soci/store/oras_content_store.go Outdated
Comment thread cmd/soci/commands/internal/standalone.go Outdated
Comment thread soci/store/oras_content_store.go Outdated
@github-actions github-actions Bot added go Pull requests that update Go code testing Unit and/or integration tests labels Feb 17, 2026
@prafgup prafgup requested a review from VVKot February 17, 2026 13:47
@prafgup prafgup force-pushed the main branch 2 times, most recently from a398342 to ff06e93 Compare February 17, 2026 14:56
@prafgup prafgup marked this pull request as draft February 18, 2026 13:53
@prafgup prafgup force-pushed the main branch 3 times, most recently from 3645f13 to 17a2cc6 Compare February 18, 2026 16:02
Comment thread cmd/soci/commands/push.go Outdated
@prafgup
Copy link
Copy Markdown
Contributor Author

prafgup commented Feb 19, 2026

#1867 #1867 (comment) would lead to merge conflicts as its touching the input flags behaviors, I would rebase with main in case that PR is merged soon. Also would refactor flags such as "standalone" as part of rebase later.

@prafgup prafgup changed the title Add standalone convert mode for SOCI index creation without containerd daemon Add standalone convert mode for SOCI index creation without containerd Feb 19, 2026
Comment on lines +92 to +96
&cli.BoolFlag{
Name: "verbose",
Aliases: []string{"v"},
Usage: "Show detailed progress output",
},
Copy link
Copy Markdown
Contributor Author

@prafgup prafgup Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also thinking of implementing something like a quiet flag instead which would be the opposite of verbose (used in push command) which would default to "always log" and when quiet is set it would not log these extra info logs.

Currently the convert command (default) anyways always outputs something like -

ztoc skipped - layer sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1 (application/vnd.oci.image.layer.v1.tar+gzip) size 32 is less than min-layer-size  10485760
...
layer sha256:3e9c02b40ec11c1a3cc84f775102e2a3b100700fc7753098adc6d62e3fc6563b -> ztoc sha256:0aa198e2f2f6ff02675b7f7dc27e008a1b81bc15a87a5e4d5f868259a3cdc5f0

thus I kept extra logging as verbose instead of making it a opt-out. Let me know if quiet makes more sense here than verbose.

Comment thread integration/standalone_convert_test.go
Comment thread cmd/soci/commands/convert.go Outdated
Comment thread cmd/soci/commands/convert.go Outdated
Comment thread cmd/soci/commands/convert.go
Signed-off-by: Praful Gupta <prafulgupta6@gmail.com>
@prafgup prafgup closed this Feb 20, 2026
@prafgup prafgup changed the title Add standalone convert mode for SOCI index creation without containerd [Closed] Add standalone convert mode for SOCI index creation without containerd Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code testing Unit and/or integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants