Use variables for all SOCI CLI flag names#1867
Merged
Merged
Conversation
This was an artifact from when we had `rpull` bundled in the CLI. As this has been removed in awslabs#998, we no longer need it. Signed-off-by: David Son <davbson@amazon.com>
Contributor
Author
|
@prafgup just an FYI since I know you're doing a large PR on the CLI. Don't want you to be blindsided by a huge rebase 🙂 |
sondavidb
force-pushed
the
cleanup-cli-flags
branch
2 times, most recently
from
1df566d to
02f6fca
Compare
Contributor
Thanks for notifying!! I'll rebase once this is merged 😓 |
prafgup
reviewed
Feb 19, 2026
prafgup
reviewed
Feb 19, 2026
prafgup
reviewed
Feb 19, 2026
Signed-off-by: David Son <davbson@amazon.com>
Should be a no-op in practice, just chores :) This should also help us to better identify dead code/flags that are no longer used in the CLI (hence the commit before this). There's still quite a few that are gangling (e.g. many of the registry flags) but some of these might be more desirable in the future. Added a "global" package as well so CLI packages can refer to globally set variables as needed. There's probably other housekeeping to be done here (internal package is a bit messy IMO) but this is a good start. Signed-off-by: David Son <davbson@amazon.com>
sondavidb
force-pushed
the
cleanup-cli-flags
branch
from
02f6fca to
d1246ed
Compare
Shubhranshu153
approved these changes
Feb 23, 2026
prafgup
approved these changes
Feb 24, 2026
Swapnanil-Gupta
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Should be a no-op in practice, just chores :)
We identified a problem in #1866 where we were looking for the value of
--usernamewhen pushing an image instead of using--user. This PR should hopefully help us avoid this mistake in the future.This should also help us to better identify dead code/flags that are no longer used in the CLI, such as the LabelFlag, which was removed in a separate commit. There's still quite a few pieces of code that are gangling (e.g. many of the registry flags) but some of these might be more desirable in the future.
Added a "global" package as well so CLI packages can refer to globally set variables as needed.
There's probably other housekeeping to be done here (internal package is a bit messy IMO) but this is a good start.
Testing performed:
Ensured the changes built via
makeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.