Skip to content

Add Spanish and Chinese translations#807

Merged
rachelekm merged 6 commits into
developfrom
feature/rkm/add-translations
Mar 12, 2026
Merged

Add Spanish and Chinese translations#807
rachelekm merged 6 commits into
developfrom
feature/rkm/add-translations

Conversation

@rachelekm

@rachelekm rachelekm commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Overview

Adds initial Spanish and Chinese translations. Noting there are come missing copy translations following the UX changes over time (documented in the project notes) so we will need a followup, but this PR should act as the first pass of applying all the translations copy.

Also includes small copy updates from client feedback.

Checklist

  • fixup! commits have been squashed
  • CHANGELOG.md updated with summary of features or fixes, following
    Keep a Changelog guidelines
  • README.md updated if necessary to reflect the changes
  • Run ./scripts/format to lint, format, and fix the application source code.
  • CI passes after rebase

Demo

Screen.Recording.2026-03-10.at.3.16.42.PM.mov
Screen.Recording.2026-03-10.at.3.16.12.PM.mov

Testing Instructions

  • scripts/server
  • Logout if necessary and set language on homepage to Spanish or Chinese
  • Register, move through user profile wizard to setup, and interact with the app so you can verify all copy appropriately translated
  • Repeat for alternate language
  • Note these will be some copy still in English, but all those should already be recorded in the project notes for a 2nd translations pass

Resolves #732

@rachelekm rachelekm requested a review from aaronxsu March 11, 2026 20:30
@rachelekm rachelekm assigned aaronxsu and unassigned aaronxsu Mar 11, 2026

@aaronxsu aaronxsu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me!

After merging this PR, would you mind creating another issue for the second round of translations after we have them back from the client? Please ignore if there's already one.

Question: for the Region filter, should we also translate North Shore, Metro West, etc? My hunch is no, but I'd like to bring it up and verify.

I also noticed there is a dollar sign $ before "Based on a map by..." in this screenshot. Is it intended?

Image

@rachelekm

Copy link
Copy Markdown
Contributor Author

Thanks for the review!

After merging this PR, would you mind creating another issue for the second round of translations after we have them back from the client? Please ignore if there's already one.

Thanks for the reminder, just made one now as a follow-up #809.

Question: for the Region filter, should we also translate North Shore, Metro West, etc? My hunch is no, but I'd like to bring it up and verify.

I'm also going to say no since these are functioning as places all users will colloquially know (similar to the neighborhood names). I'll double check with Steph and we can add it to the remaining translations list for next card if we need them.

I also noticed there is a dollar sign $ before "Based on a map by..." in this screenshot. Is it intended?

Good eye!! Not intended, looks like it's just a little hard-coded typo. I fixed it in the latest rebase e2c5908
Screenshot 2026-03-11 at 8 13 51 PM

@aaronxsu

Copy link
Copy Markdown
Member

Awesome! Good to go 👍🏼

@rachelekm rachelekm force-pushed the feature/rkm/add-translations branch from 015b41f to ba7786b Compare March 12, 2026 00:30
@rachelekm rachelekm merged commit a3ad15f into develop Mar 12, 2026
2 checks passed
@rachelekm rachelekm deleted the feature/rkm/add-translations branch March 12, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update translations

2 participants