bugfix: cacheContext not passed to sudo#219
Merged
SebastianElvis merged 2 commits intomainfrom Sep 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where state changes from sudo contract calls were persisted even when the call failed or panicked. The fix implements proper transaction atomicity by using a cache context that only commits changes on successful execution.
- Introduces cache context for atomic operations during sudo calls
- Ensures state changes are only committed on successful execution
- Prevents partial state modifications when contract execution fails
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SebastianElvis
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that we always work with a
cachedContextwhen executing sudo logic. The store will only be updated if execution completes successfully (no error or panic). This prevents partial writes and ensures state consistency.Why it matters
Without using a
CacheContext, passing a plainctx (sdk.UnwrapSDKContext(c))means that any call tostore.setor save inside a contract is written directly to the persistentMultiStore. This creates the risk of partial state commits:If an out-of-gas panic occurs after the first save, your defer may recover and return an error, but the earlier write has already been persisted. This leaves the chain in an inconsistent or unexpected state.
Solution
By wrapping the context with CacheContext, all writes are applied to a cached store. Only if execution completes without errors or panics do we commit the changes back to the main store. If an error or panic is encountered, the cached writes are discarded, ensuring atomicity of state changes.