Skip to content

bugfix: cacheContext not passed to sudo #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SebastianElvis merged 2 commits into from
Sep 8, 2025
Merged

bugfix: cacheContext not passed to sudo #219

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d46f344
bugfix: cacheContext not passed to sudo
0xAleksaOpacic Sep 2, 2025
1103ffe
add: changelog
0xAleksaOpacic Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions x/babylon/keeper/wasm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,10 @@ func (k Keeper) doSudoCallWithGasLimit(ctx sdk.Context, contractAddr sdk.AccAddr
return
}

// Create a gas-limited context
gasCtx := ctx.WithGasMeter(storetypes.NewGasMeter(maxGas))
// Create a cache context to ensure atomicity; commit only on success
cacheCtx, write := ctx.CacheContext()
// Create a gas-limited context on top of the cache context
gasCtx := cacheCtx.WithGasMeter(storetypes.NewGasMeter(maxGas))

// Use defer to recover from panics that might occur during contract execution
defer func() {
Expand All @@ -151,6 +153,8 @@ func (k Keeper) doSudoCallWithGasLimit(ctx sdk.Context, contractAddr sdk.AccAddr
return
}

// Commit cached writes only after successful execution
write()
gasConsumed = gasCtx.GasMeter().GasConsumed()

return
Expand Down
Loading