Skip to content

fix(ci): add permissions and bump docker pipeline to v0.16.1#533

Merged
RafilxTenfen merged 1 commit intomainfrom
fix/ci-workflow-permissions
Feb 6, 2026
Merged

fix(ci): add permissions and bump docker pipeline to v0.16.1#533
RafilxTenfen merged 1 commit intomainfrom
fix/ci-workflow-permissions

Conversation

@mpastecki
Copy link
Contributor

Add job-level permissions for docker_pipeline job.

Required by reusable_docker_pipeline.yml:

  • contents: read - checkout access
  • id-token: write - AWS OIDC authentication
  • security-events: write - Trivy SARIF uploads

Copilot AI review requested due to automatic review settings February 4, 2026 20:52
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds required job-level permissions to the docker_pipeline job in the CI workflow and updates the reusable docker pipeline workflow from v0.15.0 to v0.16.1. The permissions are necessary for the reusable workflow to perform checkout operations, AWS OIDC authentication, and Trivy SARIF security scan uploads.

Changes:

  • Added three permissions to the docker_pipeline job: contents:read, id-token:write, and security-events:write
  • Updated the reusable_docker_pipeline.yml reference from v0.15.0 (commit 22ae8ed) to v0.16.1 (commit d2299e8)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +24 to +27
permissions:
contents: read # Required by reusable workflow
id-token: write # Required for AWS OIDC
security-events: write # Required for Trivy SARIF uploads
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker_pipeline job is missing the packages: read permission that is present in the same job in publish.yml (line 62). According to the comment in publish.yml, this permission is "required to fetch internal or private CodeQL packs". For consistency and to ensure the workflow has all necessary permissions, this should be added here as well.

Copilot uses AI. Check for mistakes.
Comment on lines +25 to +27
contents: read # Required by reusable workflow
id-token: write # Required for AWS OIDC
security-events: write # Required for Trivy SARIF uploads
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permission comments use "Required" with only the first letter capitalized, while the same permissions in publish.yml use "REQUIRED" in all caps (see publish.yml lines 36-37, 57-58). For consistency across the codebase, consider using the same capitalization style as in publish.yml.

Copilot uses AI. Check for mistakes.
@RafilxTenfen RafilxTenfen merged commit f4fa2f6 into main Feb 6, 2026
25 checks passed
@RafilxTenfen RafilxTenfen deleted the fix/ci-workflow-permissions branch February 6, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants