Skip to content

fix(ci): add permissions and bump docker pipeline to v0.16.1 #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RafilxTenfen merged 1 commit into from
Feb 6, 2026
Merged

fix(ci): add permissions and bump docker pipeline to v0.16.1 #533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ jobs:
sudo apt-get install -y libzmq3-dev

docker_pipeline:
uses: babylonlabs-io/.github/.github/workflows/reusable_docker_pipeline.yml@22ae8ed7a2ea5c80331758914c4e0ea732eea1ad # v0.15.0
permissions:
contents: read # Required by reusable workflow
id-token: write # Required for AWS OIDC
security-events: write # Required for Trivy SARIF uploads
Comment on lines +24 to +27
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker_pipeline job is missing the packages: read permission that is present in the same job in publish.yml (line 62). According to the comment in publish.yml, this permission is "required to fetch internal or private CodeQL packs". For consistency and to ensure the workflow has all necessary permissions, this should be added here as well.

Copilot uses AI. Check for mistakes.
Comment on lines +25 to +27
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permission comments use "Required" with only the first letter capitalized, while the same permissions in publish.yml use "REQUIRED" in all caps (see publish.yml lines 36-37, 57-58). For consistency across the codebase, consider using the same capitalization style as in publish.yml.

Copilot uses AI. Check for mistakes.
uses: babylonlabs-io/.github/.github/workflows/reusable_docker_pipeline.yml@d2299e834fcbaca4bf2db043a2939798043d5951 # v0.16.1
secrets: inherit
with:
publish: false
Loading