Add a linear_fake_merge option (defaulting to True)#139
Open
cgwalters wants to merge 1 commit intobarosl:masterfrom
Open
Add a linear_fake_merge option (defaulting to True)#139cgwalters wants to merge 1 commit intobarosl:masterfrom
linear_fake_merge option (defaulting to True)#139cgwalters wants to merge 1 commit intobarosl:masterfrom
Conversation
Author
|
Thinking about this a bit more, one thing we can do is change the title of the PR to say |
This was referenced Mar 16, 2016
One of my projects (projectatomic/rpm-ostree) has a protected master branch. I was rather horrified to realize that homu force-pushes to master by default. Admittedly, I understand this is the only way to make github think the PR was merged (as opposed to just closed). But in my mind, that's a deficiency of github - it should have an API to allow us to "close merged with this commit". Anyways, add an option so that those who prefer closed over force pushing can do that today. We at least retitle the commit so that it's more clear it was merged.
cgwalters
force-pushed
the
option-disable-linear-fake-merge
branch
from
324c907 to
93067ad
Compare
Author
|
Now updated to also retitle the commit with |
|
👍 looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of my projects (projectatomic/rpm-ostree) has a protected master
branch. I was rather horrified to realize that homu force-pushes to
master by default. Admittedly, I understand this is the only way to
make github think the PR was merged (as opposed to just closed).
But in my mind, that's a deficiency of github - it should have an API
to allow us to "close merged with this commit".
Anyways, add an option so that those who prefer closing-as-unmerged over force
pushing can do that today.