Add rpmpack to the BCR repository. #1484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rpmpack) have been updated in this PR. Please review the changes. |
meteorcloudy
added
the
presubmit-auto-run
|
@jarondl Can you please address the presubmit failures? |
|
/cc @alexeagle @aiuto |
Merged
|
I took this PR and submitted a new version with minor fixes to fix CI, please check it out! #1658 |
keith
added a commit
that referenced
this pull request
Mar 21, 2024
Forked from #1484 Very minor changes compared to the original PR, I fixed the targets in the presubmit.yml, added the missing strip_prefix in the source.json, and put the correct MODULE.bazel contents here since they are already setup correctly upstream
|
mine merged so closing this one. @jarondl if you're interested the biggest change I made was reducing the number of targets being tested in the presubmit since macOS and windows don't have |
|
Random drive-by comment - on rules_oci we HAVE to test docker on Macos so we have a Testcontainers API key to get a remote docker daemon |
|
Thank you @keith ! that's super awesome. |
aiuto
pushed a commit
to aiuto/bazel-central-registry
that referenced
this pull request
Jun 3, 2024
Forked from bazelbuild#1484 Very minor changes compared to the original PR, I fixed the targets in the presubmit.yml, added the missing strip_prefix in the source.json, and put the correct MODULE.bazel contents here since they are already setup correctly upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.