Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpmpack #1658

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Add rpmpack #1658

merged 4 commits into from
Mar 21, 2024

Conversation

keith
Copy link
Member

@keith keith commented Mar 21, 2024

Forked from #1484

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rpmpack) have been updated in this PR. Please review the changes.

@keith
Copy link
Member Author

keith commented Mar 21, 2024

maybe we shouldn't send that notice for draft PRs? i think it'll take some work to get this green and reviewable

@keith keith changed the title Add rpmpack to the BCR repository. Add rpmpack Mar 21, 2024
@keith keith marked this pull request as ready for review March 21, 2024 00:36
@keith
Copy link
Member Author

keith commented Mar 21, 2024

Very minor changes compared to the original PR, I fixed the targets in the presubmit.yml, added the missing strip_prefix in the source.json, and put the correct MODULE.bazel contents here since they are already setup correctly upstream

@keith keith enabled auto-merge (squash) March 21, 2024 00:37
@meteorcloudy
Copy link
Member

maybe we shouldn't send that notice for draft PRs?

Good point, I'll fix that.

@keith keith merged commit 546a3a2 into main Mar 21, 2024
26 of 28 checks passed
aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
Forked from
bazelbuild#1484

Very minor changes compared to the original PR, I fixed the targets in the presubmit.yml, added the missing strip_prefix in the source.json, and put the correct MODULE.bazel contents here since they are already setup correctly upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants