Bazel Credential Helper Bugfix Time Format Issue #633
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix time conversion issue when converting from time.RFC3339 to time.UnixDate as this is problematic because RFC3339 is a standardized, unambiguous format with timezone information (e.g., "2023-01-01T12:00:00Z"), while UnixDate is a human-readable format without explicit timezone indicators (e.g., "Sun Jan 1 12:00:00 GMT 2023"). This conversion can lead to timezone ambiguity and parsing errors in systems expecting RFC3339 format, potentially causing authentication failures. Convert to UTC to avoid parsing errors when timezone can't be determined.
EdSchouten
suggested changes
Nov 21, 2025
go/cmd/bazelcredswrapper/main.go
Outdated
|
|
||
| fmt.Printf(`{"headers":%s, "token":"%s", "expiry":"%s"}`, jsonHdrs, | ||
| "", expiry.Format(time.UnixDate)) | ||
| "", expiry_utc.Format(time.UnixDate)) |
Collaborator
There was a problem hiding this comment.
@fitzner , do yo mind fix this suggested change, and we will merge this CL in. Thank you!
Switch to much simpler construct..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix time conversion issue when converting from time.RFC3339 to time.UnixDate as this is problematic because RFC3339 is a standardized, unambiguous format with timezone information (e.g., "2023-01-01T12:00:00Z"), while UnixDate is a human-readable format without explicit timezone indicators (e.g., "Sun Jan 1 12:00:00 GMT 2023"). This conversion can lead to timezone ambiguity and parsing errors in systems expecting RFC3339 format, potentially causing authentication failures.
Convert to UTC to avoid parsing errors when timezone can't be determined.