Skip to content

Bazel Credential Helper Bugfix Time Format Issue #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −1
Open

Bazel Credential Helper Bugfix Time Format Issue #633

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dc8601
Bugfix Time Format Issue
fitzner Nov 7, 2025
069941d
Incorporate Review Feedback
fitzner Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion go/cmd/bazelcredswrapper/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,16 @@ func main() {
log.Error(err)
os.Exit(1)
}

// Time format conversion note: Converting from time.RFC3339 to time.UnixDate is
// problematic because RFC3339 is a standardized, unambiguous format with timezone
// information (e.g., "2023-01-01T12:00:00Z"), while UnixDate is a human-readable
// format without explicit timezone indicators (e.g., "Sun Jan 1 12:00:00 GMT 2023").
// This conversion can lead to timezone ambiguity and parsing errors and potentially
// causing authentication failures.
// Convert to UTC to avoid parsing errors when timezone can't be determined.
fmt.Printf(`{"headers":%s, "token":"%s", "expiry":"%s"}`, jsonHdrs,
"", expiry.Format(time.UnixDate))
"", expiry.UTC().Format(time.UnixDate))
}

type CredshelperOut struct {
Expand Down