wip: run presubmit CI in github actions #2694
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronsky
commented
Apr 19, 2025
| @@ -28,6 +28,11 @@ bazel_dep( | |||
| dev_dependency = True, | |||
| repo_name = "com_google_protobuf", | |||
| ) | |||
| bazel_dep( | |||
| name = "buildifier_prebuilt", | |||
| version = "7.1.2", | |||
There was a problem hiding this comment.
intentionally chose this version to keep us at buildifier 6.4.0. also chose not to put this in the WORKSPACE.
|
build failures are due to insufficient permissions for |
experimenting to potentially move off of bazelci, due to various challenges. this is a 1:1 representation of the presubmit.yml as-is, meaning buildifier hasn't been updated from 6.4.0, xcode is still 16.2, and pins for doc_tests are still in place. updating buildifier and moving the stardoc/doc_tests pins should be done in a separate PR, and potentially xcode 16.3 as well (this would also allow us to more easily test a matrix of xcodes, if desired).
aaronsky
force-pushed
the
aaronsky/ci-github-actions-idea
branch
from
cfffc9a to
a87e1f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimenting to potentially move off of bazelci, due to various challenges. this is a 1:1 representation of the presubmit.yml as-is, meaning buildifier hasn't been updated from 6.4.0, xcode is still 16.2, and pins for doc_tests are still in place. it is not a 1:1 representation in terms of UX or behavior.
updating buildifier and moving the stardoc/doc_tests pins should be done in a separate PR, and potentially xcode 16.3 as well (this would also allow us to more easily test a matrix of xcodes, if desired).