-
Notifications
You must be signed in to change notification settings - Fork 290
wip: run presubmit CI in github actions #2694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aaronsky
wants to merge
8
commits into
bazelbuild:master
Choose a base branch
from
aaronsky:aaronsky/ci-github-actions-idea
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
31a8243
wip: run presubmit CI in github actions
aaronsky 14f6bcc
fail-fast: false
aaronsky 52ce9d1
only on pushes to/against master
aaronsky 261eedf
add bazel info logging like bazelci
aaronsky c0f5979
--sandbox_debug
aaronsky 723626c
stat
aaronsky a87e1f5
put things back
aaronsky a32115c
remove genrule that calls install_name_tool
aaronsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
load("@buildifier_prebuilt//:rules.bzl", "buildifier") | ||
|
||
buildifier( | ||
name = "buildifier.check", | ||
exclude_patterns = ["./.git/*"], | ||
lint_mode = "warn", | ||
mode = "diff", | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
on: | ||
push: | ||
branches: [master] | ||
pull_request: | ||
branches: [master] | ||
workflow_dispatch: | ||
|
||
# NOTE: To avoid listing the same things for build_flags/test_flags for each | ||
# of these tasks, they are listed in the .bazelrc instead. | ||
jobs: | ||
macos: | ||
runs-on: macos-15 | ||
strategy: | ||
matrix: | ||
bazel: | ||
- latest | ||
- last_rc | ||
- last_green | ||
xcode: | ||
- 16.2 | ||
fail-fast: false | ||
permissions: | ||
contents: write | ||
env: | ||
USE_BAZEL_VERSION: ${{ matrix.bazel }} | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: maxim-lobanov/setup-xcode@v1 | ||
with: | ||
xcode-version: ${{ matrix.xcode }} | ||
- uses: bazel-contrib/[email protected] | ||
with: | ||
bazelisk-cache: true | ||
disk-cache: ${{ github.workflow }} | ||
repository-cache: true | ||
bazelrc: | | ||
test --test_tag_filters=-skipci | ||
- name: Bazel Info | ||
run: | | ||
bazel version | ||
bazel info | ||
- run: bazel build tools/... test/... | ||
- run: bazel test tools/... test/... examples/... | ||
doc_tests: | ||
runs-on: ubuntu-latest | ||
env: | ||
# FIXME: Use last_green once we cherry-pick in changes needed by | ||
# https://github.com/bazelbuild/bazel/commit/b59004dd17366b09b0758b833f98294fd0e89345 | ||
# USE_BAZEL_VERSION: last_green | ||
USE_BAZEL_VERSION: 21a12c72d84e9108142421d9a8526edf8dceb78c | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: bazel-contrib/[email protected] | ||
with: | ||
bazelisk-cache: true | ||
disk-cache: ${{ github.workflow }} | ||
repository-cache: true | ||
# TODO: Remove this once stardoc is updated to 0.7.1+ (https://github.com/bazelbuild/stardoc/pull/238) | ||
bazelrc: | | ||
test --noincompatible_disallow_empty_glob | ||
- name: Bazel Info | ||
run: | | ||
bazel version | ||
bazel info | ||
- run: bazel test doc/... | ||
buildifier: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: buildifier | ||
run: bazel run --enable_bzlmod //.github/workflows:buildifier.check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intentionally chose this version to keep us at buildifier 6.4.0. also chose not to put this in the WORKSPACE.