DEP-233 and 235: add language switching in public and preview interfaces - #2870
Merged
NatSquared merged 6 commits intoJun 11, 2026
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## DEP-234-authoring-language-switching #2870 +/- ##
========================================================================
- Coverage 72.75% 72.64% -0.12%
========================================================================
Files 532 533 +1
Lines 21489 21605 +116
Branches 1855 1819 -36
========================================================================
+ Hits 15635 15694 +59
- Misses 5844 5901 +57
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jareth-whitney
approved these changes
Jun 11, 2026
jareth-whitney
left a comment
jareth-whitney
left a comment
Contributor
There was a problem hiding this comment.
Great job with this implementation of language switching. I'm excited to play around with this on on the test server. Nothing blocking, as per usual. Just check the following:
- Check engagement start/end dates are being translated from UTC to local
- Authentication-based CSS check (should be fine, just checking that it's not trying to hide anything)
| <Await resolve={engagementInfo}> | ||
| {([engagement, startDate, endDate]: [Engagement, dayjs.Dayjs | null, dayjs.Dayjs | null]) => { | ||
| {([engagement, resolvedTranslationBundle]: [Engagement, TranslationBundle | undefined]) => { | ||
| const startDate = dayjs(engagement.start_date); |
Contributor
There was a problem hiding this comment.
Just checking the start/end date get converted from UTC.
| menuName="Public Language Menu" | ||
| translationLanguages={translationLanguages} | ||
| currentLanguageCode={language} | ||
| top={isAuthenticated ? { xs: '8px', md: '12px' } : 0} |
Contributor
There was a problem hiding this comment.
Looks like this is just positioning based on whether or not an admin area control is present. Just making sure that this isn't security by obfuscation.
| } | ||
| // If there is no extension, it is a link rather than a file | ||
| if (url.indexOf('.') === -1) { | ||
| if (!url.includes('.')) { |
Contributor
There was a problem hiding this comment.
Thank you for the small optimizations throughout
| userEvent.click(dropdownMenu); | ||
| const englishMenuItem = await screen.findByRole('option', { name: 'English' }); | ||
| expect(englishMenuItem).toBeInTheDocument(); | ||
| expect(screen.getByText('engage')).toBeInTheDocument(); |
Contributor
There was a problem hiding this comment.
Thank you for adding some unit tests.
| ## June 10, 2026 | ||
|
|
||
| - **Feature** Added language switcher to public, preview engagement pages [🎟️ DEP-233](https://citz-gdx.atlassian.net/browse/DEP-233) and [🎟️ DEP-235](https://citz-gdx.atlassian.net/browse/DEP-235) | ||
| - Added a common language switcher component that can be used to switch between language views within a language context. |
Contributor
There was a problem hiding this comment.
Thanks for unifying the language switchers
|
NatSquared
merged commit Jun 11, 2026
8ac2f5d
into
DEP-234-authoring-language-switching
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: 🎟️ DEP-233 and 🎟️ DEP-235
Description of changes:
User Guide update ticket (if applicable):
Common component changes: